linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ray Jui <ray.jui@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller interrupt type
Date: Wed, 13 Jun 2018 16:32:58 -0700	[thread overview]
Message-ID: <21124af0-f867-56a9-753d-cadfce7d1cf2@broadcom.com> (raw)
In-Reply-To: <8c368dbc-f654-ec52-0786-1f318156b8b5@gmail.com>



On 6/13/2018 12:49 PM, Florian Fainelli wrote:
> On 06/12/2018 01:21 PM, Ray Jui wrote:
>> Fix I2C controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
>> Cygnus SoC
>>
>> Fixes: b51c05a331ff ("ARM: dts: add I2C device nodes for Broadcom Cygnus")
> 
> This appears to be the only one that is truly needed here, the two
> others below probably just moved things around but the offending commit
> was already introduced in the above commit.
> 

Okay thanks. Will remove the other two "Fixes" below.

>> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi bus")
>> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
>>
> 
> There is no need for an extra line between the last Fixes: tag and your
> Signed-off-by tag.
> 

Got it, thanks!

Ray

  reply	other threads:[~2018-06-13 23:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 20:21 [PATCH 0/5] Fix Cygnus, NS2, Stingray interrupt type Ray Jui
2018-06-12 20:21 ` [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller " Ray Jui
2018-06-13 19:49   ` Florian Fainelli
2018-06-13 23:32     ` Ray Jui [this message]
2018-06-13 23:33       ` Florian Fainelli
2018-06-13 23:36         ` Ray Jui
2018-06-12 20:21 ` [PATCH 2/5] ARM: dts: cygnus: Fix PCIe " Ray Jui
2018-06-13 19:50   ` Florian Fainelli
2018-06-13 23:33     ` Ray Jui
2018-06-12 20:21 ` [PATCH 3/5] ARM64: dts: ns2: Fix I2C " Ray Jui
2018-06-12 20:21 ` [PATCH 4/5] ARM64: dts: ns2: Fix PCIe " Ray Jui
2018-06-12 20:21 ` [PATCH 5/5] ARM64: dts: Stingray: Fix I2C " Ray Jui
2018-06-18 16:48 ` [PATCH 0/5] Fix Cygnus, NS2, Stingray " Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21124af0-f867-56a9-753d-cadfce7d1cf2@broadcom.com \
    --to=ray.jui@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).