From: Florian Fainelli <f.fainelli@gmail.com>
To: Ray Jui <ray.jui@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 2/5] ARM: dts: cygnus: Fix PCIe controller interrupt type
Date: Wed, 13 Jun 2018 12:50:19 -0700 [thread overview]
Message-ID: <99e3ab78-a639-5244-75a6-af39e56e7c67@gmail.com> (raw)
In-Reply-To: <1528834891-17807-3-git-send-email-ray.jui@broadcom.com>
On 06/12/2018 01:21 PM, Ray Jui wrote:
> Fix PCIe controller interrupt to use IRQ_TYPE_LEVEL_HIGH for Broadcom
> Cygnus SoC
>
> Fixes: cd590b50a936 ("ARM: dts: enable PCIe support for Cygnus")
This one is valid
> Fixes: 0f0b21a83ad2 ("ARM: dts: Move all Cygnus peripherals into axi
> bus")
> Fixes: 9c5101f7a253 ("ARM: dts: Reorder Cygnus peripherals")
> Fixes: f6b889358a82 ("ARM: dts: Enable MSI support for Broadcom Cygnus")
And this one too, but the two others, I would probably drop them so we
can get the backports to be possibly applicable as far as when these two
commits can be resolved, does that work?
>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 835a6f7..2c4df2d 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -256,7 +256,7 @@
>
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>;
> + interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>
> linux,pci-domain = <0>;
>
> @@ -278,10 +278,10 @@
> compatible = "brcm,iproc-msi";
> msi-controller;
> interrupt-parent = <&gic>;
> - interrupts = <GIC_SPI 96 IRQ_TYPE_NONE>,
> - <GIC_SPI 97 IRQ_TYPE_NONE>,
> - <GIC_SPI 98 IRQ_TYPE_NONE>,
> - <GIC_SPI 99 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
>
> @@ -291,7 +291,7 @@
>
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>;
> + interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>
> linux,pci-domain = <1>;
>
> @@ -313,10 +313,10 @@
> compatible = "brcm,iproc-msi";
> msi-controller;
> interrupt-parent = <&gic>;
> - interrupts = <GIC_SPI 102 IRQ_TYPE_NONE>,
> - <GIC_SPI 103 IRQ_TYPE_NONE>,
> - <GIC_SPI 104 IRQ_TYPE_NONE>,
> - <GIC_SPI 105 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
>
>
--
Florian
next prev parent reply other threads:[~2018-06-13 19:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 20:21 [PATCH 0/5] Fix Cygnus, NS2, Stingray interrupt type Ray Jui
2018-06-12 20:21 ` [PATCH 1/5] ARM: dts: cygnus: Fix I2C controller " Ray Jui
2018-06-13 19:49 ` Florian Fainelli
2018-06-13 23:32 ` Ray Jui
2018-06-13 23:33 ` Florian Fainelli
2018-06-13 23:36 ` Ray Jui
2018-06-12 20:21 ` [PATCH 2/5] ARM: dts: cygnus: Fix PCIe " Ray Jui
2018-06-13 19:50 ` Florian Fainelli [this message]
2018-06-13 23:33 ` Ray Jui
2018-06-12 20:21 ` [PATCH 3/5] ARM64: dts: ns2: Fix I2C " Ray Jui
2018-06-12 20:21 ` [PATCH 4/5] ARM64: dts: ns2: Fix PCIe " Ray Jui
2018-06-12 20:21 ` [PATCH 5/5] ARM64: dts: Stingray: Fix I2C " Ray Jui
2018-06-18 16:48 ` [PATCH 0/5] Fix Cygnus, NS2, Stingray " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e3ab78-a639-5244-75a6-af39e56e7c67@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).