linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ira Weiny <ira.weiny@intel.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM
Date: Sun, 21 Aug 2022 17:12:00 +0200	[thread overview]
Message-ID: <2113668.irdbgypaU6@opensuse> (raw)
In-Reply-To: <8f3e0127-91d4-af1f-ba41-951e2c5050f9@nvidia.com>

On giovedì 18 agosto 2022 17:48:04 CEST Chaitanya Kulkarni wrote:
> > -	iov_iter_kvec(&cmd->recv_msg.msg_iter, READ, cmd->iov,
> > -		cmd->nr_mapped, cmd->pdu_len);
> > +	iov_iter_kvec(&cmd->recv_msg.msg_iter, READ, cmd->iov, nr_mapped,
> > cmd->pdu_len);
> 
> >   }
> >   
> 
> 
> overly long lines above ? we are keeping lines < 80 for consistency, can
> be done at the time of applying patch.
> 
> -ck
> 

I'm sorry for this.
I changed my post commit hook and forgot to make it executable :-(
I just wrote to Sagi and said that I'm going to send a new version with the 
results of blktests. In the meantime I'll shorten those long lines below the 
80 characters threshold.

Thanks,

Fabio 



  reply	other threads:[~2022-08-21 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 18:45 [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM Fabio M. De Francesco
2022-08-18 11:45 ` Sagi Grimberg
2022-08-21 15:04   ` Fabio M. De Francesco
2022-08-18 15:48 ` Chaitanya Kulkarni
2022-08-21 15:12   ` Fabio M. De Francesco [this message]
2022-08-21  5:46 ` Christoph Hellwig
2022-08-21 19:12   ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2113668.irdbgypaU6@opensuse \
    --to=fmdefrancesco@gmail.com \
    --cc=chaitanyak@nvidia.com \
    --cc=hch@lst.de \
    --cc=ira.weiny@intel.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).