From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Keith Busch <kbusch@kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM
Date: Sun, 21 Aug 2022 21:12:30 +0200 [thread overview]
Message-ID: <8107517.T7Z3S40VBb@opensuse> (raw)
In-Reply-To: <20220821054602.GA25754@lst.de>
On domenica 21 agosto 2022 07:46:02 CEST Christoph Hellwig wrote:
> This introduced tons of pointless over 80 character lines, please stick
> to a proper coding style.
I'm sorry for this mistake. I'll break those long lines in the next version.
> Also or in-kernel I/O wouldn't it make more sense to use a BVEC iter
> insted of a KVEC if we have the pages anyway? Or does networking not
> support them properly?
I must admit I knew practically nothing about this code until I met it while
doing my long journey towards kmap() and kmap_atomic() removals. I can say the
same for regard to the differences between BVEC iter and KVEC iter.
Since you are asking this, today I did some research and read code from other
drivers/subsystems, despite this particular issue is out of the scope of my
patch.
I also read an interesting article in LWN: "The iov_iter interface" at
https://lwn.net/Articles/625077/
I may very well be wrong, however I think that iov_iter_kvec() is better
suited here.
@Sagi, anything to add to this discussion?
Thanks,
Fabio
prev parent reply other threads:[~2022-08-21 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 18:45 [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM Fabio M. De Francesco
2022-08-18 11:45 ` Sagi Grimberg
2022-08-21 15:04 ` Fabio M. De Francesco
2022-08-18 15:48 ` Chaitanya Kulkarni
2022-08-21 15:12 ` Fabio M. De Francesco
2022-08-21 5:46 ` Christoph Hellwig
2022-08-21 19:12 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8107517.T7Z3S40VBb@opensuse \
--to=fmdefrancesco@gmail.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).