* [PATCH v4 5/5] mtd: ubi: block: add option to enable scanning for partitions
@ 2022-11-08 23:04 Daniel Golle
2022-11-10 19:42 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Golle @ 2022-11-08 23:04 UTC (permalink / raw)
To: Jens Axboe, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Davidlohr Bueso, Matthew Wilcox,
Martin K. Petersen, Chaitanya Kulkarni, Daniel Golle, Ming Lei,
linux-block, linux-kernel, linux-mtd, linux-efi
Add Kconfig option CONFIG_MTD_UBI_BLOCK_PARTITIONS and enable block
partition parsers on ubiblock devices in case it is selected.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/mtd/ubi/Kconfig | 10 ++++++++++
drivers/mtd/ubi/block.c | 5 ++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
index 2ed77b7b3fcb..491330e42ab2 100644
--- a/drivers/mtd/ubi/Kconfig
+++ b/drivers/mtd/ubi/Kconfig
@@ -104,4 +104,14 @@ config MTD_UBI_BLOCK
If in doubt, say "N".
+config MTD_UBI_BLOCK_PARTITIONS
+ bool "Scan UBI block devices for partitions"
+ default y if FIT_PARTITION
+ depends on MTD_UBI_BLOCK
+ help
+ Scan UBI block devices for partitions (ie. MBR, GPT, uImage.FIT, ...).
+
+ Unless your UBI volumes contain sub-partitions mapped using a partition
+ table, say no.
+
endif # MTD_UBI
diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index 75eaecc8639f..d9baa99ca093 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -430,7 +430,10 @@ int ubiblock_create(struct ubi_volume_info *vi)
ret = -ENODEV;
goto out_cleanup_disk;
}
- gd->flags |= GENHD_FL_NO_PART;
+
+ if (!IS_ENABLED(CONFIG_MTD_UBI_BLOCK_PARTITIONS))
+ gd->flags |= GENHD_FL_NO_PART;
+
gd->private_data = dev;
sprintf(gd->disk_name, "ubiblock%d_%d", dev->ubi_num, dev->vol_id);
set_capacity(gd, disk_capacity);
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 5/5] mtd: ubi: block: add option to enable scanning for partitions
2022-11-08 23:04 [PATCH v4 5/5] mtd: ubi: block: add option to enable scanning for partitions Daniel Golle
@ 2022-11-10 19:42 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2022-11-10 19:42 UTC (permalink / raw)
To: Daniel Golle
Cc: Jens Axboe, Miquel Raynal, Vignesh Raghavendra, Davidlohr Bueso,
Matthew Wilcox, Martin K. Petersen, Chaitanya Kulkarni, Ming Lei,
linux-block, linux-kernel, linux-mtd, linux-efi
Daniel,
----- Ursprüngliche Mail -----
> Von: "Daniel Golle" <daniel@makrotopia.org>
>
> Add Kconfig option CONFIG_MTD_UBI_BLOCK_PARTITIONS and enable block
> partition parsers on ubiblock devices in case it is selected.
I think we should stick with one Kconfig at most.
Not both CONFIG_MTD_UBI_BLOCK_PARTITIONS and CONFIG_MTD_BLOCK_PARTITION.
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-10 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 23:04 [PATCH v4 5/5] mtd: ubi: block: add option to enable scanning for partitions Daniel Golle
2022-11-10 19:42 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).