* [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.
@ 2018-12-18 7:34 Doug Smythies
2018-12-19 16:55 ` Srinivas Pandruvada
2018-12-20 21:12 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Doug Smythies @ 2018-12-18 7:34 UTC (permalink / raw)
To: srinivas.pandruvada, rjw; +Cc: dsmythies, linux-kernel, linux-pm
This script is supposed to be allowed to run with regular user privileges
if a previously captured trace is being post processed.
Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
introduced a bug that breaks that option.
Commit 35459105deb26430653a7299a86bc66fb4dd5773
tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation
moved the code but kept the bug.
This patch fixes the issue.
Signed-off-by: Doug Smythies <dsmythies@telus.net>
---
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
index 84e2b64..2fa3c57 100755
--- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
+++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
@@ -585,9 +585,9 @@ current_max_cpu = 0
read_trace_data(filename)
-clear_trace_file()
-# Free the memory
if interval:
+ clear_trace_file()
+ # Free the memory
free_trace_buffer()
if graph_data_present == False:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.
2018-12-18 7:34 [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file Doug Smythies
@ 2018-12-19 16:55 ` Srinivas Pandruvada
2018-12-20 21:12 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2018-12-19 16:55 UTC (permalink / raw)
To: Doug Smythies, rjw; +Cc: dsmythies, linux-kernel, linux-pm
On Mon, 2018-12-17 at 23:34 -0800, Doug Smythies wrote:
> This script is supposed to be allowed to run with regular user
> privileges
> if a previously captured trace is being post processed.
>
> Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
> tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
> introduced a bug that breaks that option.
>
> Commit 35459105deb26430653a7299a86bc66fb4dd5773
> tools/power/x86/intel_pstate_tracer: Add optional setting of trace
> buffer memory allocation
> moved the code but kept the bug.
>
> This patch fixes the issue.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index 84e2b64..2fa3c57 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -585,9 +585,9 @@ current_max_cpu = 0
>
> read_trace_data(filename)
>
> -clear_trace_file()
> -# Free the memory
> if interval:
> + clear_trace_file()
> + # Free the memory
> free_trace_buffer()
>
> if graph_data_present == False:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file.
2018-12-18 7:34 [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file Doug Smythies
2018-12-19 16:55 ` Srinivas Pandruvada
@ 2018-12-20 21:12 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-20 21:12 UTC (permalink / raw)
To: Doug Smythies; +Cc: srinivas.pandruvada, dsmythies, linux-kernel, linux-pm
On Tuesday, December 18, 2018 8:34:04 AM CET Doug Smythies wrote:
> This script is supposed to be allowed to run with regular user privileges
> if a previously captured trace is being post processed.
>
> Commit fbe313884d7ddd73ce457473cbdf3763f5b1d3da
> tools/power/x86/intel_pstate_tracer: Free the trace buffer memory
> introduced a bug that breaks that option.
>
> Commit 35459105deb26430653a7299a86bc66fb4dd5773
> tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation
> moved the code but kept the bug.
>
> This patch fixes the issue.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
> tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> index 84e2b64..2fa3c57 100755
> --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> @@ -585,9 +585,9 @@ current_max_cpu = 0
>
> read_trace_data(filename)
>
> -clear_trace_file()
> -# Free the memory
> if interval:
> + clear_trace_file()
> + # Free the memory
> free_trace_buffer()
>
> if graph_data_present == False:
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-20 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 7:34 [PATCH] tools/power/x86/intel_pstate_tracer: Fix non root execution for post processing a trace file Doug Smythies
2018-12-19 16:55 ` Srinivas Pandruvada
2018-12-20 21:12 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).