From: Heiko Stuebner <heiko@sntech.de>
To: Andi Shyti <andi@etezian.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: andi.shyti@gmail.com, Jeffy Chen <jeffy.chen@rock-chips.com>,
Xing Zheng <zhengxing@rock-chips.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: clk-rk3*: set CLK_IS_CRITICAL flag to critical clocks
Date: Tue, 28 Jun 2016 18:32:30 +0200 [thread overview]
Message-ID: <2136865.gUkObTo8M5@phil> (raw)
In-Reply-To: <20160628160922.GN424@jack.zhora.eu>
Hi Andi,
Am Mittwoch, 29. Juni 2016, 01:09:22 schrieb Andi Shyti:
> > > RK2928_CLKSEL_CON(0), 14, 2, MFLAGS, 8, 5, DFLAGS),
> > >
> > > - GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", CLK_IGNORE_UNUSED,
> > > + GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src",
> > > + CLK_IS_CRITICAL | CLK_IGNORE_UNUSED,
> >
> > - you'll never need both critical and ignore_unused
>
> Indeed I was unsure whether I should remove the
> CLK_IGNORE_UNUSED, but then I decided to leave it because that's
> basically what the driver is currently doing. Thanks!
>
> > Happens in some more cases below, but otherwise looks ok ... as written
> > in the cover-letter I'm just still trying to make up my mind if it's
> > worth waiting for the handoff mechanism.
>
> You mean something similar (*)?
I actually mean
https://lkml.org/lkml/2016/2/11/694
which received additional comments somewhere and Mike said he wanted to
repost.
Heiko
next prev parent reply other threads:[~2016-06-28 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 14:45 [PATCH 0/2] use the CLK_IS_CRITICAL flag for critical clocks andi.shyti
2016-06-28 14:45 ` [PATCH 1/2] clk: clk-rk3*: set CLK_IS_CRITICAL flag to " andi.shyti
2016-06-28 15:17 ` Heiko Stuebner
2016-06-28 16:09 ` Andi Shyti
2016-06-28 16:32 ` Heiko Stuebner [this message]
2016-06-28 14:45 ` [PATCH 2/2] clk: rockchip: remove unused rockchip_clk_protect_critical function andi.shyti
2016-06-28 15:11 ` [PATCH 0/2] use the CLK_IS_CRITICAL flag for critical clocks Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2136865.gUkObTo8M5@phil \
--to=heiko@sntech.de \
--cc=andi.shyti@gmail.com \
--cc=andi@etezian.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).