From: Heiko Stuebner <heiko@sntech.de>
To: andi.shyti@gmail.com
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>,
Xing Zheng <zhengxing@rock-chips.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 1/2] clk: clk-rk3*: set CLK_IS_CRITICAL flag to critical clocks
Date: Tue, 28 Jun 2016 17:17:05 +0200 [thread overview]
Message-ID: <29356205.Gk5k6xKH6K@phil> (raw)
In-Reply-To: <1467125137-25999-2-git-send-email-andi@etezian.org>
Hi Andi,
Am Dienstag, 28. Juni 2016, 17:45:36 schrieb andi.shyti@gmail.com:
> From: Andi Shyti <andi@etezian.org>
>
> Patch 32b9b1096 has introduced a generalized concept of critical
> clock. Clocks are marked with the CLK_IS_CRITICAL, enabled during
> boot and never gated.
>
> Use the CLK_IS_CRITICAL instead of declaring a local array of
> critical clock enabled during boot.
>
> CC: Heiko Stuebner <heiko@sntech.de>
> CC: Jeffy Chen <jeffy.chen@rock-chips.com>
> CC: Xing Zheng <zhengxing@rock-chips.com>
> Signed-off-by: Andi Shyti <andi@etezian.org>
> ---
> drivers/clk/rockchip/clk-rk3036.c | 18 ++-----
> drivers/clk/rockchip/clk-rk3188.c | 25 +++-------
> drivers/clk/rockchip/clk-rk3228.c | 17 ++-----
> drivers/clk/rockchip/clk-rk3288.c | 21 +++-----
> drivers/clk/rockchip/clk-rk3368.c | 22 ++-------
> drivers/clk/rockchip/clk-rk3399.c | 101
> ++++++++++++++++---------------------- 6 files changed, 69 insertions(+),
> 135 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3036.c
> b/drivers/clk/rockchip/clk-rk3036.c index 924f560..5734f8c 100644
> --- a/drivers/clk/rockchip/clk-rk3036.c
> +++ b/drivers/clk/rockchip/clk-rk3036.c
> @@ -205,7 +205,8 @@ static struct rockchip_clk_branch
> rk3036_clk_branches[] __initdata = { GATE(0, "gpll_cpu", "gpll", 0,
> RK2928_CLKGATE_CON(0), 1, GFLAGS), COMPOSITE_NOGATE(0, "aclk_cpu_src",
> mux_busclk_p, 0,
> RK2928_CLKSEL_CON(0), 14, 2, MFLAGS, 8, 5, DFLAGS),
> - GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", CLK_IGNORE_UNUSED,
> + GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src",
> + CLK_IS_CRITICAL | CLK_IGNORE_UNUSED,
- you'll never need both critical and ignore_unused
- please keep the lines intact and do not introduce new line-breaks ... as
it makes reading the clock-tree way easier if the blocks share the same
format
Happens in some more cases below, but otherwise looks ok ... as written in
the cover-letter I'm just still trying to make up my mind if it's worth
waiting for the handoff mechanism.
Heiko
next prev parent reply other threads:[~2016-06-28 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 14:45 [PATCH 0/2] use the CLK_IS_CRITICAL flag for critical clocks andi.shyti
2016-06-28 14:45 ` [PATCH 1/2] clk: clk-rk3*: set CLK_IS_CRITICAL flag to " andi.shyti
2016-06-28 15:17 ` Heiko Stuebner [this message]
2016-06-28 16:09 ` Andi Shyti
2016-06-28 16:32 ` Heiko Stuebner
2016-06-28 14:45 ` [PATCH 2/2] clk: rockchip: remove unused rockchip_clk_protect_critical function andi.shyti
2016-06-28 15:11 ` [PATCH 0/2] use the CLK_IS_CRITICAL flag for critical clocks Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29356205.Gk5k6xKH6K@phil \
--to=heiko@sntech.de \
--cc=andi.shyti@gmail.com \
--cc=andi@etezian.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).