linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI / PM: Fix trailing semicolon
@ 2018-01-17 10:33 Luis de Bethencourt
  2018-01-17 18:21 ` Bjorn Helgaas
  0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-17 10:33 UTC (permalink / raw)
  To: linux-kernel; +Cc: Joe Perches, Bjorn Helgaas, linux-pci, Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].

Best regards 
Luis


[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/pci/pci-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index d79dbc377b9c..5958c8dda4e3 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
 	if (dev_pm_smart_suspend_and_suspended(dev))
 		return 0;
 
-	return pm_generic_freeze_late(dev);;
+	return pm_generic_freeze_late(dev);
 }
 
 static int pci_pm_freeze_noirq(struct device *dev)
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI / PM: Fix trailing semicolon
  2018-01-17 10:33 [PATCH] PCI / PM: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-17 18:21 ` Bjorn Helgaas
  2018-01-18  1:30   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2018-01-17 18:21 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, Joe Perches, Bjorn Helgaas, linux-pci, Rafael J. Wysocki

[+cc Rafael]

On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Rafael, I have nothing queued for pci-driver.c, and you've merged most
of the recent changes there.  If you have any pending changes to it,
feel free to merge this one.  Otherwise, I'll be happy to pick it up.

I would change the subject to:

  PCI / PM: Remove spurious semicolon

> ---
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  drivers/pci/pci-driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index d79dbc377b9c..5958c8dda4e3 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
>  	if (dev_pm_smart_suspend_and_suspended(dev))
>  		return 0;
>  
> -	return pm_generic_freeze_late(dev);;
> +	return pm_generic_freeze_late(dev);
>  }
>  
>  static int pci_pm_freeze_noirq(struct device *dev)
> -- 
> 2.15.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI / PM: Fix trailing semicolon
  2018-01-17 18:21 ` Bjorn Helgaas
@ 2018-01-18  1:30   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-01-18  1:30 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Luis de Bethencourt, linux-kernel, Joe Perches, Bjorn Helgaas,
	linux-pci, Rafael J. Wysocki

On Wednesday, January 17, 2018 7:21:49 PM CET Bjorn Helgaas wrote:
> [+cc Rafael]
> 
> On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote:
> > The trailing semicolon is an empty statement that does no operation.
> > Removing it since it doesn't do anything.
> > 
> > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Rafael, I have nothing queued for pci-driver.c, and you've merged most
> of the recent changes there.  If you have any pending changes to it,
> feel free to merge this one.  Otherwise, I'll be happy to pick it up.
> 
> I would change the subject to:
> 
>   PCI / PM: Remove spurious semicolon

OK, I'll take this one.

Thanks,
Rafael


> > ---
> > 
> > Hi,
> > 
> > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> > suggested I fix it treewide [0].
> > 
> > Best regards 
> > Luis
> > 
> > 
> > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> > 
> >  drivers/pci/pci-driver.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> > index d79dbc377b9c..5958c8dda4e3 100644
> > --- a/drivers/pci/pci-driver.c
> > +++ b/drivers/pci/pci-driver.c
> > @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
> >  	if (dev_pm_smart_suspend_and_suspended(dev))
> >  		return 0;
> >  
> > -	return pm_generic_freeze_late(dev);;
> > +	return pm_generic_freeze_late(dev);
> >  }
> >  
> >  static int pci_pm_freeze_noirq(struct device *dev)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-18  1:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 10:33 [PATCH] PCI / PM: Fix trailing semicolon Luis de Bethencourt
2018-01-17 18:21 ` Bjorn Helgaas
2018-01-18  1:30   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).