* [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming()
@ 2021-04-08 13:36 Lu Jialin
2021-04-11 18:18 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Lu Jialin @ 2021-04-08 13:36 UTC (permalink / raw)
To: lujialin4, Jernej Skrabec, Mauro Carvalho Chehab, Maxime Ripard,
Chen-Yu Tsai, Philipp Zabel
Cc: linux-media, linux-arm-kernel, linux-sunxi, kernel-janitors,
linux-kernel
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lu Jialin <lujialin4@huawei.com>
---
drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
index ed863bf5ea80..671e4a928993 100644
--- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
+++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c
@@ -589,7 +589,7 @@ static int deinterlace_start_streaming(struct vb2_queue *vq, unsigned int count)
int ret;
if (V4L2_TYPE_IS_OUTPUT(vq->type)) {
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
dev_err(dev, "Failed to enable module\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming()
2021-04-08 13:36 [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Lu Jialin
@ 2021-04-11 18:18 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2021-04-11 18:18 UTC (permalink / raw)
To: lujialin4, Mauro Carvalho Chehab, Maxime Ripard, Chen-Yu Tsai,
Philipp Zabel, Lu Jialin
Cc: linux-media, linux-arm-kernel, linux-sunxi, kernel-janitors,
linux-kernel
Dne četrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a):
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Lu Jialin <lujialin4@huawei.com>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-11 18:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 13:36 [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Lu Jialin
2021-04-11 18:18 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).