* [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure
@ 2018-11-16 11:50 Ahmed Abd El Mawgood
2018-11-16 12:58 ` Andrew Jones
0 siblings, 1 reply; 5+ messages in thread
From: Ahmed Abd El Mawgood @ 2018-11-16 11:50 UTC (permalink / raw)
To: Shuah Khan, Paolo Bonzini, Andrew Jones, Peter Xu,
Colin Ian King, linux-kselftest, linux-kernel, Hossam Hassan,
Ahmed Lotfy, Vitaly Kuznetsov, Anders Roxell
Cc: Ahmed Abd El Mawgood
From: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
madvise() returns -1 without CONFIG_TRANSPARENT_HUGEPAGE=y. That would
trigger asserts when checking for return value of madvice. Following
similar decision to [1]. I thought it is ok to assume that madvise()
MADV_NOHUGEPAGE failures implies that THP is not supported by host kernel.
Other options was to check for Transparent Huge Page support in
/sys/kernel/mm/transparent_hugepage/enabled.
-- links --
[1] https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04514.html
Signed-off-by: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
---
tools/testing/selftests/kvm/lib/kvm_util.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index 1b41e71283d5..437c5bb48061 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -586,14 +586,23 @@ void vm_userspace_mem_region_add(struct kvm_vm *vm,
src_type == VM_MEM_SRC_ANONYMOUS_THP ? huge_page_size : 1);
/* As needed perform madvise */
- if (src_type == VM_MEM_SRC_ANONYMOUS || src_type == VM_MEM_SRC_ANONYMOUS_THP) {
+ if (src_type == VM_MEM_SRC_ANONYMOUS) {
+ /*
+ * Neglect madvise error because it is ok to not have THP
+ * support in this case.
+ */
+ madvise(region->host_mem, npages * vm->page_size,
+ MADV_NOHUGEPAGE);
+ } else if (src_type == VM_MEM_SRC_ANONYMOUS_THP) {
ret = madvise(region->host_mem, npages * vm->page_size,
- src_type == VM_MEM_SRC_ANONYMOUS ? MADV_NOHUGEPAGE : MADV_HUGEPAGE);
+ MADV_HUGEPAGE);
TEST_ASSERT(ret == 0, "madvise failed,\n"
- " addr: %p\n"
- " length: 0x%lx\n"
- " src_type: %x",
- region->host_mem, npages * vm->page_size, src_type);
+ "Does the kernel have CONFIG_TRANSPARENT_HUGEPAGE=y\n"
+ " addr: %p\n"
+ " length: 0x%lx\n"
+ " src_type: %x\n",
+ region->host_mem, npages * vm->page_size,
+ src_type);
}
region->unused_phy_pages = sparsebit_alloc();
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure
2018-11-16 11:50 [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure Ahmed Abd El Mawgood
@ 2018-11-16 12:58 ` Andrew Jones
2018-12-24 14:56 ` Ahmed Soliman
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Jones @ 2018-11-16 12:58 UTC (permalink / raw)
To: Ahmed Abd El Mawgood
Cc: Shuah Khan, Paolo Bonzini, Peter Xu, Colin Ian King,
linux-kselftest, linux-kernel, Hossam Hassan, Ahmed Lotfy,
Vitaly Kuznetsov, Anders Roxell
On Fri, Nov 16, 2018 at 01:50:55PM +0200, Ahmed Abd El Mawgood wrote:
> From: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
>
> madvise() returns -1 without CONFIG_TRANSPARENT_HUGEPAGE=y. That would
> trigger asserts when checking for return value of madvice. Following
> similar decision to [1]. I thought it is ok to assume that madvise()
> MADV_NOHUGEPAGE failures implies that THP is not supported by host kernel.
>
> Other options was to check for Transparent Huge Page support in
> /sys/kernel/mm/transparent_hugepage/enabled.
>
> -- links --
> [1] https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04514.html
>
> Signed-off-by: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1b41e71283d5..437c5bb48061 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -586,14 +586,23 @@ void vm_userspace_mem_region_add(struct kvm_vm *vm,
> src_type == VM_MEM_SRC_ANONYMOUS_THP ? huge_page_size : 1);
>
> /* As needed perform madvise */
> - if (src_type == VM_MEM_SRC_ANONYMOUS || src_type == VM_MEM_SRC_ANONYMOUS_THP) {
> + if (src_type == VM_MEM_SRC_ANONYMOUS) {
> + /*
> + * Neglect madvise error because it is ok to not have THP
> + * support in this case.
> + */
> + madvise(region->host_mem, npages * vm->page_size,
> + MADV_NOHUGEPAGE);
> + } else if (src_type == VM_MEM_SRC_ANONYMOUS_THP) {
> ret = madvise(region->host_mem, npages * vm->page_size,
> - src_type == VM_MEM_SRC_ANONYMOUS ? MADV_NOHUGEPAGE : MADV_HUGEPAGE);
> + MADV_HUGEPAGE);
> TEST_ASSERT(ret == 0, "madvise failed,\n"
> - " addr: %p\n"
> - " length: 0x%lx\n"
> - " src_type: %x",
> - region->host_mem, npages * vm->page_size, src_type);
> + "Does the kernel have CONFIG_TRANSPARENT_HUGEPAGE=y\n"
> + " addr: %p\n"
> + " length: 0x%lx\n"
> + " src_type: %x\n",
> + region->host_mem, npages * vm->page_size,
> + src_type);
> }
>
> region->unused_phy_pages = sparsebit_alloc();
> --
> 2.18.1
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure
2018-11-16 12:58 ` Andrew Jones
@ 2018-12-24 14:56 ` Ahmed Soliman
2018-12-27 0:44 ` shuah
0 siblings, 1 reply; 5+ messages in thread
From: Ahmed Soliman @ 2018-12-24 14:56 UTC (permalink / raw)
To: Shuah Khan, Andrew Jones
Cc: Paolo Bonzini, Peter Xu, Colin Ian King, linux-kselftest,
linux-kernel, Hossam Hassan, Ahmed Lotfy, Vitaly Kuznetsov,
Anders Roxell
Kind reminder to merge my patch into next
thanks.
On Fri, Nov 16, 2018 at 2:59 PM Andrew Jones <drjones@redhat.com> wrote:
>
> On Fri, Nov 16, 2018 at 01:50:55PM +0200, Ahmed Abd El Mawgood wrote:
> > From: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
> >
> > madvise() returns -1 without CONFIG_TRANSPARENT_HUGEPAGE=y. That would
> > trigger asserts when checking for return value of madvice. Following
> > similar decision to [1]. I thought it is ok to assume that madvise()
> > MADV_NOHUGEPAGE failures implies that THP is not supported by host kernel.
> >
> > Other options was to check for Transparent Huge Page support in
> > /sys/kernel/mm/transparent_hugepage/enabled.
> >
> > -- links --
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04514.html
> >
> > Signed-off-by: Ahmed Abd El Mawgood <ahmedsoliman@mena.vt.edu>
> > ---
> > tools/testing/selftests/kvm/lib/kvm_util.c | 21 +++++++++++++++------
> > 1 file changed, 15 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> > index 1b41e71283d5..437c5bb48061 100644
> > --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> > @@ -586,14 +586,23 @@ void vm_userspace_mem_region_add(struct kvm_vm *vm,
> > src_type == VM_MEM_SRC_ANONYMOUS_THP ? huge_page_size : 1);
> >
> > /* As needed perform madvise */
> > - if (src_type == VM_MEM_SRC_ANONYMOUS || src_type == VM_MEM_SRC_ANONYMOUS_THP) {
> > + if (src_type == VM_MEM_SRC_ANONYMOUS) {
> > + /*
> > + * Neglect madvise error because it is ok to not have THP
> > + * support in this case.
> > + */
> > + madvise(region->host_mem, npages * vm->page_size,
> > + MADV_NOHUGEPAGE);
> > + } else if (src_type == VM_MEM_SRC_ANONYMOUS_THP) {
> > ret = madvise(region->host_mem, npages * vm->page_size,
> > - src_type == VM_MEM_SRC_ANONYMOUS ? MADV_NOHUGEPAGE : MADV_HUGEPAGE);
> > + MADV_HUGEPAGE);
> > TEST_ASSERT(ret == 0, "madvise failed,\n"
> > - " addr: %p\n"
> > - " length: 0x%lx\n"
> > - " src_type: %x",
> > - region->host_mem, npages * vm->page_size, src_type);
> > + "Does the kernel have CONFIG_TRANSPARENT_HUGEPAGE=y\n"
> > + " addr: %p\n"
> > + " length: 0x%lx\n"
> > + " src_type: %x\n",
> > + region->host_mem, npages * vm->page_size,
> > + src_type);
> > }
> >
> > region->unused_phy_pages = sparsebit_alloc();
> > --
> > 2.18.1
> >
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
--
Junior Researcher, IoT and Cyber Security lab, SmartCI, Alexandria
University, & CIS @ VMI
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure
2018-12-24 14:56 ` Ahmed Soliman
@ 2018-12-27 0:44 ` shuah
2019-01-07 23:20 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: shuah @ 2018-12-27 0:44 UTC (permalink / raw)
To: Ahmed Soliman, Andrew Jones, Paolo Bonzini
Cc: Peter Xu, Colin Ian King, linux-kselftest, linux-kernel,
Hossam Hassan, Ahmed Lotfy, Vitaly Kuznetsov, Anders Roxell,
shuah
Hi Paolo,
On 12/24/18 7:56 AM, Ahmed Soliman wrote:
> Kind reminder to merge my patch into next
>
> thanks.
>
I am assuming you will be picking this patch up. Please let me know if
you want me to take it through kselftest tree.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure
2018-12-27 0:44 ` shuah
@ 2019-01-07 23:20 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2019-01-07 23:20 UTC (permalink / raw)
To: shuah, Ahmed Soliman, Andrew Jones
Cc: Peter Xu, Colin Ian King, linux-kselftest, linux-kernel,
Hossam Hassan, Ahmed Lotfy, Vitaly Kuznetsov, Anders Roxell
On 27/12/18 01:44, shuah wrote:
> Hi Paolo,
>
> On 12/24/18 7:56 AM, Ahmed Soliman wrote:
>> Kind reminder to merge my patch into next
>>
>> thanks.
>>
>
> I am assuming you will be picking this patch up. Please let me know if
> you want me to take it through kselftest tree.
Yes, I was on vacataion but I'm back now.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-07 23:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-16 11:50 [PATCH V2] SelfTest: KVM: Drop Asserts for madvise MADV_NOHUGEPAGE failure Ahmed Abd El Mawgood
2018-11-16 12:58 ` Andrew Jones
2018-12-24 14:56 ` Ahmed Soliman
2018-12-27 0:44 ` shuah
2019-01-07 23:20 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).