From: Yu Tu <yu.tu@amlogic.com>
To: Jiri Slaby <jirislaby@kernel.org>, <linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH V6 3/5] tty: serial: meson: Describes the calculation of the UART baud rate clock using a clock frame
Date: Wed, 19 Jan 2022 14:00:44 +0800 [thread overview]
Message-ID: <21eea0cd-5bf1-dec6-a776-f417aefa5bda@amlogic.com> (raw)
In-Reply-To: <7a8016ba-730b-f599-2032-31cf03990a55@kernel.org>
Hi Jiri,
Thank you very much for your patient reply.I learned a lot from your
response.
On 2022/1/18 17:39, Jiri Slaby wrote:
> [ EXTERNAL EMAIL ]
>
> On 18. 01. 22, 4:09, Yu Tu wrote:
>> Using the common Clock code to describe the UART baud rate clock
>> makes it easier for the UART driver to be compatible with the
>> baud rate requirements of the UART IP on different meson chips.
> ...
>> --- a/drivers/tty/serial/meson_uart.c
>> +++ b/drivers/tty/serial/meson_uart.c
> ...
>> @@ -629,57 +640,105 @@ static struct uart_driver meson_uart_driver = {
>> .cons = MESON_SERIAL_CONSOLE,
>> };
>> -static inline struct clk *meson_uart_probe_clock(struct device *dev,
>> - const char *id)
>> -{
>> - struct clk *clk = NULL;
>> - int ret;
>> -
>> - clk = devm_clk_get(dev, id);
>> - if (IS_ERR(clk))
>> - return clk;
>> -
>> - ret = clk_prepare_enable(clk);
>> - if (ret) {
>> - dev_err(dev, "couldn't enable clk\n");
>> - return ERR_PTR(ret);
>> - }
>> -
>> - devm_add_action_or_reset(dev,
>> - (void(*)(void *))clk_disable_unprepare,
>> - clk);
>> -
>> - return clk;
>> -}
>> +static struct clk_div_table xtal_div_table[] = {
>
> This can be const, right?
You are right.
>
>> + {0, 3},
>> + {1, 1},
>> + {2, 2},
>> + {3, 2},
>
> Not sure if you didn't remove too much whitespace. I think it should be
> like: "{ 0, 3 },". But I actually don't care, it's a minor thing.
>
Ok, I will correct it if it needs to be changed.
> I cannot comment on the rest (clk and OF part) as my knowledge is pretty
> limited there. Leaving up to others.
>
Anyway, thanks for your reply.
> thanks,
next prev parent reply other threads:[~2022-01-19 6:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 3:09 [PATCH V6 0/5] Use CCF to describe the UART baud rate clock Yu Tu
2022-01-18 3:09 ` [PATCH V6 1/5] tty: serial: meson: Move request the register region to probe Yu Tu
2022-01-18 9:35 ` Jiri Slaby
2022-01-18 3:09 ` [PATCH V6 2/5] tty: serial: meson: Use devm_ioremap_resource to get register mapped memory Yu Tu
2022-01-18 9:36 ` Jiri Slaby
2022-01-18 3:09 ` [PATCH V6 3/5] tty: serial: meson: Describes the calculation of the UART baud rate clock using a clock frame Yu Tu
2022-01-18 9:39 ` Jiri Slaby
2022-01-19 6:00 ` Yu Tu [this message]
2022-01-20 21:48 ` Jerome Brunet
2022-02-21 8:26 ` Yu Tu
2022-01-20 21:40 ` Jerome Brunet
2022-01-21 2:51 ` Yu Tu
2022-02-21 8:52 ` Yu Tu
2022-01-18 3:09 ` [PATCH V6 4/5] tty: serial: meson: Make some bit of the REG5 register writable Yu Tu
2022-01-20 21:49 ` Jerome Brunet
2022-02-21 8:24 ` Yu Tu
2022-01-18 3:09 ` [PATCH V6 5/5] tty: serial: meson: Added S4 SOC compatibility Yu Tu
2022-01-19 22:37 ` [PATCH V6 0/5] Use CCF to describe the UART baud rate clock Kevin Hilman
2022-01-20 8:43 ` Yu Tu
2022-01-24 19:58 ` Kevin Hilman
2022-02-07 14:19 ` Yu Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21eea0cd-5bf1-dec6-a776-f417aefa5bda@amlogic.com \
--to=yu.tu@amlogic.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).