linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] PM / suspend: show workqueue state in suspend flow
@ 2016-07-01  3:05 Roger Lu
  2016-07-01 16:09 ` Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Lu @ 2016-07-01  3:05 UTC (permalink / raw)
  To: Rafael J . Wysocki, Pavel Machek, Len Brown, Tejun Heo
  Cc: srv_heupstream, linux-mediatek, Sascha Hauer, Lai Jiangshan,
	Matthias Brugger, linux-pm, linux-kernel, linux-arm-kernel,
	Roger Lu

If freezable workqueue aborts suspend flow, show
workqueue state for debug purpose.

Signed-off-by: Roger Lu <roger.lu@mediatek.com>
---
Changes in v2:
- remove prints in show_workqueue_state().
---
 kernel/power/process.c | 3 +++
 kernel/workqueue.c     | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/kernel/power/process.c b/kernel/power/process.c
index df058be..6eef250 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -89,6 +89,9 @@ static int try_to_freeze_tasks(bool user_only)
 		       elapsed_msecs / 1000, elapsed_msecs % 1000,
 		       todo - wq_busy, wq_busy);
 
+		if (wq_busy)
+			show_workqueue_state();
+
 		if (!wakeup) {
 			read_lock(&tasklist_lock);
 			for_each_process_thread(g, p) {
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e1c0e99..619e80c 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4369,8 +4369,8 @@ static void show_pwq(struct pool_workqueue *pwq)
 /**
  * show_workqueue_state - dump workqueue state
  *
- * Called from a sysrq handler and prints out all busy workqueues and
- * pools.
+ * Called from a sysrq handler or try_to_freeze_tasks() and prints out
+ * all busy workqueues and pools.
  */
 void show_workqueue_state(void)
 {
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] PM / suspend: show workqueue state in suspend flow
  2016-07-01  3:05 [PATCH v2] PM / suspend: show workqueue state in suspend flow Roger Lu
@ 2016-07-01 16:09 ` Tejun Heo
  2016-07-01 21:09   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2016-07-01 16:09 UTC (permalink / raw)
  To: Roger Lu
  Cc: Rafael J . Wysocki, Pavel Machek, Len Brown, srv_heupstream,
	linux-mediatek, Sascha Hauer, Lai Jiangshan, Matthias Brugger,
	linux-pm, linux-kernel, linux-arm-kernel

On Fri, Jul 01, 2016 at 11:05:02AM +0800, Roger Lu wrote:
> If freezable workqueue aborts suspend flow, show
> workqueue state for debug purpose.
> 
> Signed-off-by: Roger Lu <roger.lu@mediatek.com>

Acked-by: Tejun Heo <tj@kernel.org>

Rafael, can you please pick this on up?

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] PM / suspend: show workqueue state in suspend flow
  2016-07-01 16:09 ` Tejun Heo
@ 2016-07-01 21:09   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-07-01 21:09 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Roger Lu, Pavel Machek, Len Brown, srv_heupstream,
	linux-mediatek, Sascha Hauer, Lai Jiangshan, Matthias Brugger,
	linux-pm, linux-kernel, linux-arm-kernel

On Friday, July 01, 2016 11:09:42 AM Tejun Heo wrote:
> On Fri, Jul 01, 2016 at 11:05:02AM +0800, Roger Lu wrote:
> > If freezable workqueue aborts suspend flow, show
> > workqueue state for debug purpose.
> > 
> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Rafael, can you please pick this on up?

I will.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-01 21:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-01  3:05 [PATCH v2] PM / suspend: show workqueue state in suspend flow Roger Lu
2016-07-01 16:09 ` Tejun Heo
2016-07-01 21:09   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).