* [PATCH] staging: erofs: dir.c fix "alignment should match open parenthesis" issues
@ 2019-03-03 22:37 Dominik Adamski
2019-03-03 23:20 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Adamski @ 2019-03-03 22:37 UTC (permalink / raw)
Cc: adamski.dominik, Gao Xiang, Chao Yu, Greg Kroah-Hartman,
linux-erofs, devel, linux-kernel
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Dominik Adamski <adamski.dominik@gmail.com>
---
drivers/staging/erofs/dir.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
index 833f052f79d0..e1955703ab8f 100644
--- a/drivers/staging/erofs/dir.c
+++ b/drivers/staging/erofs/dir.c
@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
};
static int erofs_fill_dentries(struct dir_context *ctx,
- void *dentry_blk, unsigned int *ofs,
- unsigned int nameoff, unsigned int maxsize)
+ void *dentry_blk, unsigned int *ofs,
+ unsigned int nameoff, unsigned int maxsize)
{
struct erofs_dirent *de = dentry_blk;
const struct erofs_dirent *end = dentry_blk + nameoff;
@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
nameoff = le16_to_cpu(de->nameoff);
if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
- nameoff >= PAGE_SIZE)) {
+ nameoff >= PAGE_SIZE)) {
errln("%s, invalid de[0].nameoff %u",
- __func__, nameoff);
+ __func__, nameoff);
err = -EIO;
goto skip_this;
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: erofs: dir.c fix "alignment should match open parenthesis" issues
2019-03-03 22:37 [PATCH] staging: erofs: dir.c fix "alignment should match open parenthesis" issues Dominik Adamski
@ 2019-03-03 23:20 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2019-03-03 23:20 UTC (permalink / raw)
To: Dominik Adamski; +Cc: devel, Greg Kroah-Hartman, linux-kernel, linux-erofs
On 2019/3/4 6:37, Dominik Adamski wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
>
> Signed-off-by: Dominik Adamski <adamski.dominik@gmail.com>
> ---
> drivers/staging/erofs/dir.c | 8 ++++----
duplicated commit...
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/erofs/dir.c?h=staging-next&id=cbebe5d05dd7fe2fdd13cff7c4a62f22109f1f95
Thanks,
Gao Xiang
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c
> index 833f052f79d0..e1955703ab8f 100644
> --- a/drivers/staging/erofs/dir.c
> +++ b/drivers/staging/erofs/dir.c
> @@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
> };
>
> static int erofs_fill_dentries(struct dir_context *ctx,
> - void *dentry_blk, unsigned int *ofs,
> - unsigned int nameoff, unsigned int maxsize)
> + void *dentry_blk, unsigned int *ofs,
> + unsigned int nameoff, unsigned int maxsize)
> {
> struct erofs_dirent *de = dentry_blk;
> const struct erofs_dirent *end = dentry_blk + nameoff;
> @@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
> nameoff = le16_to_cpu(de->nameoff);
>
> if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
> - nameoff >= PAGE_SIZE)) {
> + nameoff >= PAGE_SIZE)) {
> errln("%s, invalid de[0].nameoff %u",
> - __func__, nameoff);
> + __func__, nameoff);
>
> err = -EIO;
> goto skip_this;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-03 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-03 22:37 [PATCH] staging: erofs: dir.c fix "alignment should match open parenthesis" issues Dominik Adamski
2019-03-03 23:20 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).