From: "Reshetova, Elena" <elena.reshetova@intel.com>
To: Dmitry Vyukov <dvyukov@google.com>, Mark Rutland <mark.rutland@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Anders Roxell <anders.roxell@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
"Peter Zijlstra" <peterz@infradead.org>
Subject: RE: [PATCH] kcov: convert kcov.refcount to refcount_t
Date: Thu, 31 Jan 2019 10:03:55 +0000 [thread overview]
Message-ID: <2236FBA76BA1254E88B949DDB74E612BA4B9BBF9@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <CACT4Y+Y6JNyQ+SSZXDSYVcBXZ_e1Hf3OMpoz=1eqGNhNKqYikg@mail.gmail.com>
> Just to check, has this been tested with CONFIG_REFCOUNT_FULL and
> > something poking kcov?
> >
> > Given lib/refcount.c is instrumented, the refcount_*() calls will
> > recurse back into the kcov code. It looks like that's fine, given these
> > are only manipulated in setup/teardown paths, but it would be nice to be
> > sure.
>
> A simple program using KCOV is available here:
> https://elixir.bootlin.com/linux/v5.0-rc3/source/Documentation/dev-
> tools/kcov.rst#L42
> or here (it's like strace but collects and prints KCOV coverage):
> https://github.com/google/syzkaller/blob/master/tools/kcovtrace/kcovtrace.c
>
Ok, so I finally got to compile kcov in and try the first test program
and it works fine as far as I can see: runs, prints results, and no WARNs anywhere
visible with regards to refcount_t.
I did my test on 4.20 with CONFIG_REFCOUNT_FULL=y
since I have serious issues getting 5.0 running as it is even from
the stable branch, but unless kcov underwent some serious changes since December,
it should not affect.
Is it ok now for merging this change? The stricter mem ordering on dec_and_test
hopefully will also lands soon.
Best Regards,
Elena.
next prev parent reply other threads:[~2019-01-31 10:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 10:27 [PATCH] kcov: convert kcov.refcount to refcount_t Elena Reshetova
2019-01-16 12:51 ` Dmitry Vyukov
2019-01-21 9:52 ` Dmitry Vyukov
2019-01-21 11:45 ` Andrea Parri
2019-01-21 12:29 ` Dmitry Vyukov
2019-01-21 14:44 ` Andrea Parri
2019-01-21 13:18 ` Peter Zijlstra
2019-01-21 16:05 ` Alan Stern
2019-01-21 17:00 ` Dmitry Vyukov
2019-01-22 9:04 ` Peter Zijlstra
2019-01-22 23:22 ` Kees Cook
2019-01-25 9:02 ` Reshetova, Elena
2019-01-25 10:31 ` Peter Zijlstra
2019-01-27 18:41 ` Reshetova, Elena
2019-01-28 8:33 ` Dmitry Vyukov
2019-01-28 9:28 ` Peter Zijlstra
2019-01-21 11:51 ` Andrea Parri
2019-01-21 12:38 ` Mark Rutland
2019-01-21 12:42 ` Dmitry Vyukov
2019-01-21 14:07 ` Reshetova, Elena
2019-01-21 17:07 ` Dmitry Vyukov
2019-01-31 10:03 ` Reshetova, Elena [this message]
2019-01-31 10:06 ` Dmitry Vyukov
2019-01-31 10:09 ` Reshetova, Elena
2019-01-31 10:33 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2236FBA76BA1254E88B949DDB74E612BA4B9BBF9@IRSMSX102.ger.corp.intel.com \
--to=elena.reshetova@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).