From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Martin Povišer" <povik@cutebit.org>
Cc: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Mark Kettenis" <kettenis@openbsd.org>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>
Subject: Re: [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system
Date: Thu, 31 Mar 2022 10:26:07 +0200 [thread overview]
Message-ID: <224d1d98-5d6f-515e-feef-a1ebf20a90d9@linaro.org> (raw)
In-Reply-To: <E5F73642-DF9A-46ED-B310-7D69CAE22C82@cutebit.org>
On 31/03/2022 10:23, Martin Povišer wrote:
>
>> There should be some maximum of supported codecs. Hardware might have
>> such constraints. If really unsure, choose some reasonable (small)
>> amount. It could be later raised, if needed.
>
> There are some constraints but technically not in the driver that binds
> on this binding. I thought no limit is better than an arbitrary one, but
> if the preference is to have one, I will add it, no problem.
Just to clarify this - bindings are not about the driver, but about the
hardware. We model here the hardware and its programming model, not the
driver implementation (although of course it's always somehow related).
Hardware has some limitations for sure. The question is whether we know
them. :)
I prefer even arbitrary limit, because then schema will check DTSes for
simple mistakes. You can also explain this in commit msg, that maxItems
are arbitrary, so whoever in the future wants to change it, will know
the background.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-31 8:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 0:04 [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system Martin Povišer
2022-03-31 6:43 ` Krzysztof Kozlowski
2022-03-31 6:57 ` Martin Povišer
2022-03-31 8:17 ` Krzysztof Kozlowski
2022-03-31 8:23 ` Martin Povišer
2022-03-31 8:26 ` Krzysztof Kozlowski [this message]
2022-03-31 0:04 ` [RFC PATCH 2/5] HACK: ASoC: Add card->filter_controls hook Martin Povišer
2022-03-31 11:34 ` Mark Brown
2022-03-31 0:04 ` [RFC PATCH 3/5] HACK: ASoC: Tolerate N-cpus-to-M-codecs links Martin Povišer
2022-04-04 12:28 ` Mark Brown
2022-04-22 14:06 ` Martin Povišer
2022-04-25 12:25 ` Mark Brown
2022-04-25 12:34 ` Martin Povišer
2022-04-25 12:55 ` Mark Brown
2022-04-25 13:11 ` Martin Povišer
2022-04-25 13:46 ` Mark Brown
2022-04-25 13:55 ` Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 4/5] ASoC: Introduce snd_soc_of_get_dai_link_cpus Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 5/5] ASoC: Add macaudio machine driver Martin Povišer
2022-03-31 11:59 ` Mark Brown
2022-03-31 12:08 ` Martin Povišer
2022-03-31 12:16 ` Martin Povišer
2022-03-31 12:56 ` Mark Brown
2022-03-31 12:34 ` [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Mark Brown
2022-03-31 13:28 ` Martin Povišer
2022-03-31 14:18 ` Mark Brown
2022-03-31 15:04 ` Martin Povišer
2022-03-31 15:36 ` Mark Brown
2022-04-22 10:43 ` Martin Povišer
2022-04-22 11:19 ` Mark Brown
2022-04-22 11:28 ` Martin Povišer
2022-04-22 11:33 ` Mark Brown
2022-04-22 11:44 ` Martin Povišer
2022-04-22 12:22 ` Mark Brown
2022-04-22 12:36 ` Martin Povišer
2022-04-22 12:44 ` Mark Brown
2022-04-22 12:53 ` Martin Povišer
2022-04-22 13:06 ` Mark Brown
2022-04-22 13:59 ` Martin Povišer
2022-03-31 13:28 ` Hector Martin
2022-03-31 14:33 ` Mark Brown
2022-04-05 9:31 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224d1d98-5d6f-515e-feef-a1ebf20a90d9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=povik@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).