Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver

From: Mark Brown <broonie@kernel.org>
To: "Martin Povišer" <povik@cutebit.org>
Cc: "Martin Povišer" <povik+lin@cutebit.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Mark Kettenis" <kettenis@openbsd.org>,
	"Hector Martin" <marcan@marcan.st>,
	"Sven Peter" <sven@svenpeter.dev>
Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver
Date: Thu, 31 Mar 2022 16:36:59 +0100	[thread overview]
Message-ID: <YkXKmxJ0R3qpUoH4@sirena.org.uk> (raw)
In-Reply-To: <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org>

[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]

On Thu, Mar 31, 2022 at 05:04:32PM +0200, Martin Povišer wrote:
> > On 31. 3. 2022, at 16:18, Mark Brown <broonie@kernel.org> wrote:

> > Yes, having two devices driving the bus at the same time wouldn't be
> > great.  How is the TDM slot selection for the signals done in the
> > hardware, I'm not seeing anything immediately obvious in the driver?
> > I'd have thought that things would be implemented such that you could
> > implement speaker protection on all speakers simultaneously but perhaps
> > not.

> I don’t know. I would have to go study the details of this. Should I see
> if I can find a combination of ‘ASI1 Sel’ ‘VSENSE’ ‘ISENSE’ settings
> that would lead to driver conflict on one of the models, or is there
> a chance we could hide those controls just on the basis of ‘it doesn’t
> do anything usable and is possibly dangerous’?

If ISENSE and VSENSE output are controlled by the same mux as routing
then we should lock one of the controls out for at least stereo devices
(it might be a good idea to check if the output is actually high Z when
ISENSE and VSENSE are off rather than just driving zeros, if not it
definitely has to be the routing control).  My instinct is that it's
better to preserve the ability to implement speaker protection in future
since that is something that'd be broadly useful, especially if someone
comes up with a generic speaker protection implementation in which case
there should be an awful lot of systems out there which could benefit. 

> >> That’s the reasoning anyway. To reiterate, seems to me the controls
> >> are useless/confusing at best and dangerous at worst.

> > I'm just not seeing an issue for the slot selection.

> Yeah, agreed there’s no (damage) issue as we should to proper volume
> caps anyway.

Though see above about how ISENSE/VSENSE output slot is controlled I guess :/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]