* [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
@ 2022-07-02 3:19 Samuel Holland
2022-07-02 19:34 ` Jernej Škrabec
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Samuel Holland @ 2022-07-02 3:19 UTC (permalink / raw)
To: Vinod Koul
Cc: Samuel Holland, Chen-Yu Tsai, Jernej Skrabec,
Krzysztof Kozlowski, Maxime Ripard, Rob Herring, devicetree,
dmaengine, linux-arm-kernel, linux-kernel, linux-sunxi
The conditional block for variants with a second clock should have set
minItems, not maxItems, which was already 2. Since clock-names requires
two items, this typo should not have caused any problems.
Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64 DMA to a schema")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
.../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
index ff0a5c58d78c..e712444abff1 100644
--- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
@@ -67,7 +67,7 @@ if:
then:
properties:
clocks:
- maxItems: 2
+ minItems: 2
required:
- clock-names
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
2022-07-02 3:19 [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo Samuel Holland
@ 2022-07-02 19:34 ` Jernej Škrabec
2022-07-05 20:28 ` Rob Herring
2022-07-05 20:28 ` Rob Herring
2022-07-06 16:27 ` Vinod Koul
2 siblings, 1 reply; 5+ messages in thread
From: Jernej Škrabec @ 2022-07-02 19:34 UTC (permalink / raw)
To: Vinod Koul, Samuel Holland
Cc: Samuel Holland, Chen-Yu Tsai, Krzysztof Kozlowski, Maxime Ripard,
Rob Herring, devicetree, dmaengine, linux-arm-kernel,
linux-kernel, linux-sunxi
Dne sobota, 02. julij 2022 ob 05:19:02 CEST je Samuel Holland napisal(a):
> The conditional block for variants with a second clock should have set
> minItems, not maxItems, which was already 2. Since clock-names requires
> two items, this typo should not have caused any problems.
>
> Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64
> DMA to a schema") Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index
> ff0a5c58d78c..e712444abff1 100644
> --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> @@ -67,7 +67,7 @@ if:
> then:
> properties:
> clocks:
> - maxItems: 2
> + minItems: 2
These specific variants have exactly 2 clocks. Having both limits seems right.
Best regards,
Jernej
>
> required:
> - clock-names
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
2022-07-02 19:34 ` Jernej Škrabec
@ 2022-07-05 20:28 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-07-05 20:28 UTC (permalink / raw)
To: Jernej Škrabec
Cc: Vinod Koul, Samuel Holland, Chen-Yu Tsai, Krzysztof Kozlowski,
Maxime Ripard, devicetree, dmaengine, linux-arm-kernel,
linux-kernel, linux-sunxi
On Sat, Jul 02, 2022 at 09:34:41PM +0200, Jernej Škrabec wrote:
> Dne sobota, 02. julij 2022 ob 05:19:02 CEST je Samuel Holland napisal(a):
> > The conditional block for variants with a second clock should have set
> > minItems, not maxItems, which was already 2. Since clock-names requires
> > two items, this typo should not have caused any problems.
> >
> > Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64
> > DMA to a schema") Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> >
> > .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index
> > ff0a5c58d78c..e712444abff1 100644
> > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > @@ -67,7 +67,7 @@ if:
> > then:
> > properties:
> > clocks:
> > - maxItems: 2
> > + minItems: 2
>
> These specific variants have exactly 2 clocks. Having both limits seems right.
You do. The main section has 2 for the max.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
2022-07-02 3:19 [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo Samuel Holland
2022-07-02 19:34 ` Jernej Škrabec
@ 2022-07-05 20:28 ` Rob Herring
2022-07-06 16:27 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-07-05 20:28 UTC (permalink / raw)
To: Samuel Holland
Cc: Rob Herring, linux-sunxi, Vinod Koul, Chen-Yu Tsai, dmaengine,
linux-arm-kernel, Jernej Skrabec, Krzysztof Kozlowski,
Maxime Ripard, devicetree, linux-kernel
On Fri, 01 Jul 2022 22:19:02 -0500, Samuel Holland wrote:
> The conditional block for variants with a second clock should have set
> minItems, not maxItems, which was already 2. Since clock-names requires
> two items, this typo should not have caused any problems.
>
> Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64 DMA to a schema")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
2022-07-02 3:19 [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo Samuel Holland
2022-07-02 19:34 ` Jernej Škrabec
2022-07-05 20:28 ` Rob Herring
@ 2022-07-06 16:27 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2022-07-06 16:27 UTC (permalink / raw)
To: Samuel Holland
Cc: Chen-Yu Tsai, Jernej Skrabec, Krzysztof Kozlowski, Maxime Ripard,
Rob Herring, devicetree, dmaengine, linux-arm-kernel,
linux-kernel, linux-sunxi
On 01-07-22, 22:19, Samuel Holland wrote:
> The conditional block for variants with a second clock should have set
> minItems, not maxItems, which was already 2. Since clock-names requires
> two items, this typo should not have caused any problems.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-06 16:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-02 3:19 [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo Samuel Holland
2022-07-02 19:34 ` Jernej Škrabec
2022-07-05 20:28 ` Rob Herring
2022-07-05 20:28 ` Rob Herring
2022-07-06 16:27 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).