* [PATCH] mm: Fix two spelling mistakes in highmem.h
@ 2023-01-05 12:13 Fabio M. De Francesco
2023-01-05 17:02 ` Ira Weiny
0 siblings, 1 reply; 3+ messages in thread
From: Fabio M. De Francesco @ 2023-01-05 12:13 UTC (permalink / raw)
To: Andrew Morton, Ira Weiny, Sebastian Andrzej Siewior,
Alexander Potapenko, Bagas Sanjaya, Andrey Konovalov, Tony Luck,
linux-kernel, Matthew Wilcox (Oracle),
linux-mm
Cc: Fabio M. De Francesco
Substitute two occurrencies of "higmem" with "highmem" in highmem.h.
Suggested-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
include/linux/highmem.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/highmem.h b/include/linux/highmem.h
index 7b0085a61e67..ae1670ccdf45 100644
--- a/include/linux/highmem.h
+++ b/include/linux/highmem.h
@@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
* virtual address of the direct mapping. Only real highmem pages are
* temporarily mapped.
*
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
* comes with restrictions about the pointer validity.
*
* On HIGHMEM enabled systems mapping a highmem page has the side effect of
@@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page *page);
* virtual address of the direct mapping. Only real highmem pages are
* temporarily mapped.
*
- * While it is significantly faster than kmap() for the higmem case it
+ * While it is significantly faster than kmap() for the highmem case it
* comes with restrictions about the pointer validity.
*
* On HIGHMEM enabled systems mapping a highmem page has the side effect of
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Fix two spelling mistakes in highmem.h
2023-01-05 12:13 [PATCH] mm: Fix two spelling mistakes in highmem.h Fabio M. De Francesco
@ 2023-01-05 17:02 ` Ira Weiny
2023-01-09 18:09 ` Fabio M. De Francesco
0 siblings, 1 reply; 3+ messages in thread
From: Ira Weiny @ 2023-01-05 17:02 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: Andrew Morton, Sebastian Andrzej Siewior, Alexander Potapenko,
Bagas Sanjaya, Andrey Konovalov, Tony Luck, linux-kernel,
Matthew Wilcox (Oracle),
linux-mm
On Thu, Jan 05, 2023 at 01:13:05PM +0100, Fabio M. De Francesco wrote:
> Substitute two occurrencies of "higmem" with "highmem" in highmem.h.
The change looks fine but for Andrew's benefit I believe this patch is based on
the other one you submitted to fix kmap_local_folio()?[1] Is that correct?
[1] https://lore.kernel.org/all/20230105120424.30055-1-fmdefrancesco@gmail.com/
With that note:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> Suggested-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> include/linux/highmem.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index 7b0085a61e67..ae1670ccdf45 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
> * virtual address of the direct mapping. Only real highmem pages are
> * temporarily mapped.
> *
> - * While it is significantly faster than kmap() for the higmem case it
> + * While it is significantly faster than kmap() for the highmem case it
> * comes with restrictions about the pointer validity.
> *
> * On HIGHMEM enabled systems mapping a highmem page has the side effect of
> @@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page *page);
> * virtual address of the direct mapping. Only real highmem pages are
> * temporarily mapped.
> *
> - * While it is significantly faster than kmap() for the higmem case it
> + * While it is significantly faster than kmap() for the highmem case it
> * comes with restrictions about the pointer validity.
> *
> * On HIGHMEM enabled systems mapping a highmem page has the side effect of
> --
> 2.39.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Fix two spelling mistakes in highmem.h
2023-01-05 17:02 ` Ira Weiny
@ 2023-01-09 18:09 ` Fabio M. De Francesco
0 siblings, 0 replies; 3+ messages in thread
From: Fabio M. De Francesco @ 2023-01-09 18:09 UTC (permalink / raw)
To: Ira Weiny
Cc: Andrew Morton, Sebastian Andrzej Siewior, Alexander Potapenko,
Bagas Sanjaya, Andrey Konovalov, Tony Luck, linux-kernel,
Matthew Wilcox (Oracle),
linux-mm
On giovedì 5 gennaio 2023 18:02:30 CET Ira Weiny wrote:
> On Thu, Jan 05, 2023 at 01:13:05PM +0100, Fabio M. De Francesco wrote:
> > Substitute two occurrences of "higmem" with "highmem" in highmem.h.
>
> The change looks fine but for Andrew's benefit I believe this patch is based
> on the other one you submitted to fix kmap_local_folio()?[1] Is that
> correct?
Yes, it is.
I had completely forgotten that previous patch.
Thanks for noticing it and for providing its link to Andrew.
Fabio
>
> [1]
> https://lore.kernel.org/all/20230105120424.30055-1-fmdefrancesco@gmail.com/
>
> With that note:
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> > Suggested-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > include/linux/highmem.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> > index 7b0085a61e67..ae1670ccdf45 100644
> > --- a/include/linux/highmem.h
> > +++ b/include/linux/highmem.h
> > @@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
> >
> > * virtual address of the direct mapping. Only real highmem pages are
> > * temporarily mapped.
> > *
> >
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> >
> > * comes with restrictions about the pointer validity.
> > *
> > * On HIGHMEM enabled systems mapping a highmem page has the side effect
of
> >
> > @@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page
*page);
> >
> > * virtual address of the direct mapping. Only real highmem pages are
> > * temporarily mapped.
> > *
> >
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> >
> > * comes with restrictions about the pointer validity.
> > *
> > * On HIGHMEM enabled systems mapping a highmem page has the side effect
of
> >
> > --
> > 2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-09 18:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 12:13 [PATCH] mm: Fix two spelling mistakes in highmem.h Fabio M. De Francesco
2023-01-05 17:02 ` Ira Weiny
2023-01-09 18:09 ` Fabio M. De Francesco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).