From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Alan Maguire <alan.maguire@oracle.com>,
jdike@addtoit.com, richard@nod.at, alex.dewar@gmx.co.uk,
erelx.geron@intel.com, johannes.berg@intel.com, arnd@arndb.de,
linux-um@lists.infradead.org
Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc
Date: Fri, 20 Mar 2020 15:57:20 +0000 [thread overview]
Message-ID: <2295c218-74a6-d785-f4b1-2046ee91503a@cambridgegreys.com> (raw)
In-Reply-To: <1584466534-13248-1-git-send-email-alan.maguire@oracle.com>
On 17/03/2020 17:35, Alan Maguire wrote:
> When building UML with glibc 2.17 installed, compilation
> of arch/um/os-Linux/file.c fails due to failure to find
> FALLOC_FL_PUNCH_HOLE and FALLOC_FL_KEEP_SIZE definitions.
>
> It appears that /usr/include/bits/fcntl-linux.h (indirectly
> included by /usr/include/fcntl.h) does not include falloc.h
> with an older glibc, whereas a more up-to-date version
> does.
>
> Adding the direct include to file.c resolves the issue
> and does not cause problems for more recent glibc.
>
> Fixes: 50109b5a03b4 ("um: Add support for DISCARD in the UBD Driver")
> Cc: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> ---
> arch/um/os-Linux/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
> index fbda105..5c819f8 100644
> --- a/arch/um/os-Linux/file.c
> +++ b/arch/um/os-Linux/file.c
> @@ -8,6 +8,7 @@
> #include <errno.h>
> #include <fcntl.h>
> #include <signal.h>
> +#include <linux/falloc.h>
> #include <sys/ioctl.h>
> #include <sys/mount.h>
> #include <sys/socket.h>
>
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
next prev parent reply other threads:[~2020-03-20 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:35 [PATCH] arch/um: falloc.h needs to be directly included for older libc Alan Maguire
2020-03-17 19:00 ` Brendan Higgins
2020-03-20 15:57 ` Anton Ivanov [this message]
2020-03-29 21:41 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2295c218-74a6-d785-f4b1-2046ee91503a@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=alan.maguire@oracle.com \
--cc=alex.dewar@gmx.co.uk \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=erelx.geron@intel.com \
--cc=jdike@addtoit.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).