From: Chris Mason <mason@suse.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: "Stephen C. Tweedie" <sct@redhat.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linus Torvalds <torvalds@transmeta.com>,
Russell Cattelan <cattelan@thebarn.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)
Date: Fri, 22 Dec 2000 08:49:09 -0500 [thread overview]
Message-ID: <232360000.977492949@coffee> (raw)
In-Reply-To: <Pine.GSO.4.21.0012212048210.5877-100000@weyl.math.psu.edu>
On Thursday, December 21, 2000 20:54:09 -0500 Alexander Viro <viro@math.psu.edu> wrote:
>
>
> On Thu, 21 Dec 2000, Chris Mason wrote:
>
>> Obvious bug, block_write_full_page zeros out the bits past the end of
>> file every time. This should not be needed for normal file writes.
>
> Unfortunately, it _is_ needed for pageout path. mmap() the last page
> of file. Dirty the data past the EOF (MMU will not catch that access).
> Let the pageout send the page to disk. You don't want to have the data
> past EOF end up on the backstore.
>
Sorry, I wasn't very clear. I'd like to find a way to just do the memset in the one case it is needed (a real writepage), and not do it when we are using writepage just to flush dirty buffers. I don't see how to do it though, without making a new flush operation. That would also solve my concerns about the change in writepage semantics (even though every FS I could find in the kernel tree was using block_write_full_page).
thanks,
Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-22 14:21 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3A398F84.2CD3039D@thebarn.com>
2000-12-15 6:20 ` Test12 ll_rw_block error Linus Torvalds
2000-12-15 7:00 ` Alexander Viro
2000-12-15 9:14 ` Chris Mason
2000-12-17 0:54 ` Russell Cattelan
2000-12-17 12:20 ` Chris Mason
2000-12-15 10:51 ` Stephen C. Tweedie
2000-12-15 19:04 ` Linus Torvalds
2000-12-17 1:08 ` Russell Cattelan
2000-12-18 11:44 ` Stephen C. Tweedie
2000-12-17 2:38 ` Marcelo Tosatti
2000-12-18 11:46 ` Stephen C. Tweedie
2000-12-19 14:05 ` Marcelo Tosatti
2000-12-19 16:43 ` Daniel Phillips
2000-12-19 17:18 ` Marcelo Tosatti
2000-12-19 17:40 ` Christoph Hellwig
2000-12-21 23:25 ` [RFC] changes to buffer.c (was Test12 ll_rw_block error) Chris Mason
2000-12-22 0:19 ` Marcelo Tosatti
2000-12-22 2:20 ` Andreas Dilger
2000-12-22 0:38 ` Marcelo Tosatti
2000-12-22 13:56 ` Chris Mason
2000-12-22 16:45 ` Daniel Phillips
2000-12-22 19:35 ` Chris Mason
2000-12-22 15:07 ` Chris Mason
2000-12-22 19:52 ` Marcelo Tosatti
2000-12-22 23:18 ` Chris Mason
2000-12-22 23:26 ` Marcelo Tosatti
2000-12-23 18:21 ` Chris Mason
2000-12-23 19:02 ` Linus Torvalds
2000-12-23 19:25 ` Chris Mason
2000-12-23 15:47 ` Daniel Phillips
2000-12-27 0:57 ` Chris Mason
2000-12-26 23:18 ` Marcelo Tosatti
2000-12-27 20:26 ` Daniel Phillips
2000-12-27 20:49 ` Chris Mason
2000-12-28 15:49 ` Daniel Phillips
2000-12-28 19:19 ` Chris Mason
2000-12-28 19:29 ` Linus Torvalds
2000-12-29 16:03 ` Chris Mason
2000-12-29 16:21 ` Marcelo Tosatti
2000-12-29 18:33 ` Alexander Viro
2001-01-05 15:54 ` Chris Mason
2001-01-05 15:43 ` Marcelo Tosatti
2001-01-05 17:49 ` Daniel Phillips
2001-01-05 17:52 ` Chris Mason
2001-01-05 19:51 ` Chris Mason
2001-01-05 18:32 ` Marcelo Tosatti
2001-01-05 20:29 ` Rik van Riel
2001-01-05 18:43 ` Marcelo Tosatti
2001-01-05 20:37 ` Rik van Riel
2001-01-05 21:08 ` Chris Mason
2001-01-05 18:09 ` Juergen Schneider
2000-12-29 17:58 ` Daniel Phillips
2001-01-02 15:49 ` Chris Mason
2000-12-22 1:54 ` Alexander Viro
2000-12-22 13:49 ` Chris Mason [this message]
2000-12-17 0:51 ` Test12 ll_rw_block error Russell Cattelan
2000-12-17 0:21 ` Russell Cattelan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232360000.977492949@coffee \
--to=mason@suse.com \
--cc=cattelan@thebarn.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=sct@redhat.com \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).