* [PATCH] sched/fair: Remove unneeded prototype of capacity_of()
@ 2019-01-02 13:55 Valentin Schneider
2019-01-04 9:15 ` Quentin Perret
2019-01-28 8:34 ` Valentin Schneider
0 siblings, 2 replies; 3+ messages in thread
From: Valentin Schneider @ 2019-01-02 13:55 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, peterz, morten.rasmussen, quentin.perret, Dietmar.Eggemann
The prototype of that function was already hoisted up in
commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
but that seems to have been missed. Get rid of the extra prototype.
Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 6483834f1278..6d653947a829 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
#ifdef CONFIG_SMP
static inline unsigned long cpu_util(int cpu);
-static unsigned long capacity_of(int cpu);
static inline bool cpu_overutilized(int cpu)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: Remove unneeded prototype of capacity_of()
2019-01-02 13:55 [PATCH] sched/fair: Remove unneeded prototype of capacity_of() Valentin Schneider
@ 2019-01-04 9:15 ` Quentin Perret
2019-01-28 8:34 ` Valentin Schneider
1 sibling, 0 replies; 3+ messages in thread
From: Quentin Perret @ 2019-01-04 9:15 UTC (permalink / raw)
To: Valentin Schneider
Cc: linux-kernel, mingo, peterz, morten.rasmussen, Dietmar.Eggemann
Hi Valentin,
On Wednesday 02 Jan 2019 at 13:55:49 (+0000), Valentin Schneider wrote:
> The prototype of that function was already hoisted up in
>
> commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
>
> but that seems to have been missed.
Indeed, I missed that one :/
> Get rid of the extra prototype.
>
> Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
> kernel/sched/fair.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6483834f1278..6d653947a829 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
>
> #ifdef CONFIG_SMP
> static inline unsigned long cpu_util(int cpu);
> -static unsigned long capacity_of(int cpu);
>
> static inline bool cpu_overutilized(int cpu)
> {
> --
> 2.20.1
Acked-by: Quentin Perret <quentin.perret@arm.com>
Thanks for cleaning this up,
Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: Remove unneeded prototype of capacity_of()
2019-01-02 13:55 [PATCH] sched/fair: Remove unneeded prototype of capacity_of() Valentin Schneider
2019-01-04 9:15 ` Quentin Perret
@ 2019-01-28 8:34 ` Valentin Schneider
1 sibling, 0 replies; 3+ messages in thread
From: Valentin Schneider @ 2019-01-28 8:34 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, peterz, morten.rasmussen, quentin.perret, Dietmar.Eggemann
Hi,
On 02/01/2019 13:55, Valentin Schneider wrote:
> The prototype of that function was already hoisted up in
>
> commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
>
> but that seems to have been missed. Get rid of the extra prototype.
>
> Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
I had forgotten about that one... Ping.
> ---
> kernel/sched/fair.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6483834f1278..6d653947a829 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
>
> #ifdef CONFIG_SMP
> static inline unsigned long cpu_util(int cpu);
> -static unsigned long capacity_of(int cpu);
>
> static inline bool cpu_overutilized(int cpu)
> {
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-28 8:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 13:55 [PATCH] sched/fair: Remove unneeded prototype of capacity_of() Valentin Schneider
2019-01-04 9:15 ` Quentin Perret
2019-01-28 8:34 ` Valentin Schneider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).