From: Finn Thain <fthain@linux-m68k.org>
To: Tom Rix <trix@redhat.com>
Cc: Joe Perches <joe@perches.com>,
Bart Van Assche <bvanassche@acm.org>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com, Konrad Kleine <kkleine@redhat.com>,
megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
Date: Thu, 3 Mar 2022 19:35:25 +1100 (AEDT) [thread overview]
Message-ID: <233660d0-1dee-7d80-1581-2e6845bf7689@linux-m68k.org> (raw)
In-Reply-To: <8dd05afd-0bb9-c91b-6393-aff69f1363e1@redhat.com>
On Wed, 2 Mar 2022, Tom Rix wrote:
> >>> Long term, it would be good have a reliable way to automatically fix
> >>> either new files or really broken old files.
> >> That's really a maintainer preference no?
> >>
> >> Especially so for any automation.
> >
> > In practice everything is up to the maintainer.
> >
> > If some maintainer wants fix their formatting then clang-format should
> > just work
> >
> > It isn't likely they will have time to hand fix every file.
>
> A follow up issue in the clang project has been raised by Konrad, here
>
> https://github.com/llvm/llvm-project/issues/54137
>
Why request a "leave" option for every style rule? Why not just a "leave"
option for the most contentious rules?
The response from the developers that anyone who wants to leave existing
code unmolested by certain rules should "wake up and smell the coffee" is
obnoxious, IMO.
Presumably clang-format must grow until it has sufficient program logic
and config options to cater to every exception to every rule. How long
will that take? Some carefully chosen "leave" options might make the
program much more useful in the near term.
> Tom
>
>
> >
> > Tom
> >
> >>
> >>
>
next prev parent reply other threads:[~2022-03-03 8:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:19 [PATCH] scsi: megaraid: cleanup formatting of megaraid trix
2022-01-27 22:37 ` Finn Thain
2022-01-27 22:47 ` Nick Desaulniers
2022-01-28 0:32 ` Tom Rix
2022-01-28 2:43 ` Joe Perches
2022-01-28 5:31 ` Tom Rix
2022-01-28 8:41 ` Joe Perches
2022-01-28 15:30 ` Tom Rix
2022-01-28 16:23 ` Joe Perches
2022-01-28 23:45 ` Finn Thain
2022-01-28 9:39 ` Miguel Ojeda
2022-01-28 17:42 ` Bart Van Assche
2022-01-28 17:59 ` Tom Rix
2022-01-28 19:11 ` Joe Perches
2022-01-28 19:37 ` Tom Rix
2022-03-02 19:14 ` Tom Rix
2022-03-03 8:35 ` Finn Thain [this message]
2022-03-03 11:41 ` Konrad Wilhelm Kleine
[not found] ` <CABRYuGk+1AGpvfkR7=LTCm+bN4kt55fwQnQXCjidSXWxuMWsiQ@mail.gmail.com>
2022-03-03 22:44 ` Finn Thain
2022-03-03 23:17 ` Miguel Ojeda
2022-03-03 23:38 ` Joe Perches
2022-03-04 5:22 ` Bart Van Assche
2022-03-04 5:40 ` Joe Perches
2022-03-05 3:22 ` Finn Thain
2022-03-04 7:47 ` Finn Thain
2022-03-04 12:31 ` Miguel Ojeda
2022-03-04 13:46 ` Tom Rix
2022-03-04 14:02 ` Miguel Ojeda
2022-03-04 17:36 ` Joe Perches
2022-03-04 18:48 ` Miguel Ojeda
2022-03-04 19:28 ` Joe Perches
2022-03-04 21:04 ` Miguel Ojeda
2022-03-05 3:32 ` Finn Thain
2022-03-04 22:38 ` Tom Rix
2022-01-28 20:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=233660d0-1dee-7d80-1581-2e6845bf7689@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=kashyap.desai@broadcom.com \
--cc=kkleine@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).