From: Finn Thain <fthain@linux-m68k.org>
To: Tom Rix <trix@redhat.com>
Cc: Joe Perches <joe@perches.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
Date: Sat, 29 Jan 2022 10:45:53 +1100 (AEDT) [thread overview]
Message-ID: <56b761a-6cf9-23ab-c849-eff27e5e831e@linux-m68k.org> (raw)
In-Reply-To: <0567fce4-256a-e1b1-dc66-221ba97153d5@redhat.com>
On Fri, 28 Jan 2022, Tom Rix wrote:
> A testsuite for the fixers may help with churn
>
> Any interest or thought on organization ?
>
Here's one way:
1. Identify some source files that are exemplary (i.e. good style).
2. Run a new script to introduce style mistakes into those files.
3. Run the Reformatter Under Test on those files.
4. Compare the output with the original files.
But that's not sufficient to prevent more style patches (churn). We still
need a way to avoid wasting everyone's time writing, submitting, reviewing
and merging the inevitably incomplete style patches that may contain
regressions and cause conflicts.
The tooling I would like to see is not a script to introduce style
mistakes but an editor for binaries, such that C is not the "source" at
all but only an ephemeral representation to make it easier for humans to
effect changes to binaries (and debug info, commentary etc.)
Nonetheless, perfecting the clang-format tool is a good step towards a
better workflow, which I described once before.
https://lore.kernel.org/r/alpine.LNX.2.23.453.2010281344120.31@nippy.intranet/
next prev parent reply other threads:[~2022-01-28 23:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:19 [PATCH] scsi: megaraid: cleanup formatting of megaraid trix
2022-01-27 22:37 ` Finn Thain
2022-01-27 22:47 ` Nick Desaulniers
2022-01-28 0:32 ` Tom Rix
2022-01-28 2:43 ` Joe Perches
2022-01-28 5:31 ` Tom Rix
2022-01-28 8:41 ` Joe Perches
2022-01-28 15:30 ` Tom Rix
2022-01-28 16:23 ` Joe Perches
2022-01-28 23:45 ` Finn Thain [this message]
2022-01-28 9:39 ` Miguel Ojeda
2022-01-28 17:42 ` Bart Van Assche
2022-01-28 17:59 ` Tom Rix
2022-01-28 19:11 ` Joe Perches
2022-01-28 19:37 ` Tom Rix
2022-03-02 19:14 ` Tom Rix
2022-03-03 8:35 ` Finn Thain
2022-03-03 11:41 ` Konrad Wilhelm Kleine
[not found] ` <CABRYuGk+1AGpvfkR7=LTCm+bN4kt55fwQnQXCjidSXWxuMWsiQ@mail.gmail.com>
2022-03-03 22:44 ` Finn Thain
2022-03-03 23:17 ` Miguel Ojeda
2022-03-03 23:38 ` Joe Perches
2022-03-04 5:22 ` Bart Van Assche
2022-03-04 5:40 ` Joe Perches
2022-03-05 3:22 ` Finn Thain
2022-03-04 7:47 ` Finn Thain
2022-03-04 12:31 ` Miguel Ojeda
2022-03-04 13:46 ` Tom Rix
2022-03-04 14:02 ` Miguel Ojeda
2022-03-04 17:36 ` Joe Perches
2022-03-04 18:48 ` Miguel Ojeda
2022-03-04 19:28 ` Joe Perches
2022-03-04 21:04 ` Miguel Ojeda
2022-03-05 3:32 ` Finn Thain
2022-03-04 22:38 ` Tom Rix
2022-01-28 20:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b761a-6cf9-23ab-c849-eff27e5e831e@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).