* [PATCH] rxrpc: add IPV6 dependency
@ 2018-10-12 12:36 Arnd Bergmann
2018-10-12 14:25 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-10-12 12:36 UTC (permalink / raw)
To: David Howells, David S. Miller
Cc: Arnd Bergmann, linux-afs, linux-kernel, netdev
The udpv6_encap_enable() function is part of the ipv6 code, and if that
is configured as a loadable module, rxcpc cannot be built-in any more:
net/rxrpc/local_object.o: In function `rxrpc_lookup_local':
local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable'
Add a dependency that allows building rxrpc with or without IPv6, but
that disallows the broken configuration. Since AFS selects RXRPC,
this needs the same dependency.
Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/afs/Kconfig | 1 +
net/rxrpc/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/fs/afs/Kconfig b/fs/afs/Kconfig
index ebba3b18e5da..e2cad2c9d9d8 100644
--- a/fs/afs/Kconfig
+++ b/fs/afs/Kconfig
@@ -1,6 +1,7 @@
config AFS_FS
tristate "Andrew File System support (AFS)"
depends on INET
+ depends on IPV6 || !IPV6
select AF_RXRPC
select DNS_RESOLVER
help
diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index 86f8853a038c..d925be00fc74 100644
--- a/net/rxrpc/Kconfig
+++ b/net/rxrpc/Kconfig
@@ -5,6 +5,7 @@
config AF_RXRPC
tristate "RxRPC session sockets"
depends on INET
+ depends on IPV6 || !IPV6
select CRYPTO
select KEYS
help
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rxrpc: add IPV6 dependency
2018-10-12 12:36 [PATCH] rxrpc: add IPV6 dependency Arnd Bergmann
@ 2018-10-12 14:25 ` David Howells
2018-10-12 15:33 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2018-10-12 14:25 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: dhowells, David S. Miller, linux-afs, linux-kernel, netdev
Arnd Bergmann <arnd@arndb.de> wrote:
> + depends on IPV6 || !IPV6
That looks weird. It looks like it always ought to be true.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rxrpc: add IPV6 dependency
2018-10-12 14:25 ` David Howells
@ 2018-10-12 15:33 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2018-10-12 15:33 UTC (permalink / raw)
To: David Howells, Arnd Bergmann
Cc: David S. Miller, linux-afs, linux-kernel, netdev
On 10/12/18 7:25 AM, David Howells wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
>
>> + depends on IPV6 || !IPV6
>
> That looks weird. It looks like it always ought to be true.
It's a common idiom in Kconfig.
It prevents AF_RXRPC=y and IPV6=m, resulting in this build error.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-12 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-12 12:36 [PATCH] rxrpc: add IPV6 dependency Arnd Bergmann
2018-10-12 14:25 ` David Howells
2018-10-12 15:33 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).