* Re: [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets [not found] ` <20160823064451.25997-2-icenowy@aosc.xyz> @ 2016-08-24 19:32 ` Maxime Ripard [not found] ` <43601472083053@web23m.yandex.ru> 0 siblings, 1 reply; 8+ messages in thread From: Maxime Ripard @ 2016-08-24 19:32 UTC (permalink / raw) To: Icenowy Zheng Cc: Russell King, Chen-Yu Tsai, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 4825 bytes --] Hi, On Tue, Aug 23, 2016 at 02:44:50PM +0800, Icenowy Zheng wrote: > The inet-d978_rev2 is a pcb used in generic A33 based tablets. It features > volume buttons, micro-usb otg, headphone connector and a power button. > > On the board a Realtek RTL8723BS SDIO Wi-Fi module are soldered, and there > is also a accompanied board which has a Goodix GT9271 soldered. > > As this board is desired to create tablets with a Home key dealed by > GT9271, a LED is present at the front panel at the position of the > Home key. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 87 ++++++++++++++++++++++++++ > 2 files changed, 88 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index faacd52..d1812a0 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -782,6 +782,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > sun8i-a23-q8-tablet.dtb \ > sun8i-a33-et-q8-v1.6.dtb \ > sun8i-a33-ga10h-v1.1.dtb \ > + sun8i-a33-inet-d978-rev2.dtb \ > sun8i-a33-ippo-q8h-v1.2.dtb \ > sun8i-a33-q8-tablet.dtb \ > sun8i-a33-sinlinx-sina33.dtb \ > diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > new file mode 100644 > index 0000000..78823d8 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > @@ -0,0 +1,87 @@ > +/* > + * Copyright 2015 Hans de Goede <hdegoede@redhat.com> I guess you are the author too :) > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun8i-a33.dtsi" > +#include "sun8i-reference-design-tablet.dtsi" > + > +/ { > + model = "INet-D978 Rev 02"; > + compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&led_pin_d978>; > + > + home { > + label = "d978:home"; This is not the proper format for the led labels. It's supposed to be <board>:<color>:<function> > + gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ > + }; > + }; > +}; > + > +&mmc1_pins_a { > + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; > +}; > + > +&mmc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc1_pins_a>; > + vmmc-supply = <®_dldo1>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + rtl8723bs: sdio_wifi@1 { > + reg = <1>; > + }; Don't you need an alias to this node to have the MAC address set? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <43601472083053@web23m.yandex.ru>]
* Re: [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets [not found] ` <43601472083053@web23m.yandex.ru> @ 2016-08-25 7:35 ` Maxime Ripard 0 siblings, 0 replies; 8+ messages in thread From: Maxime Ripard @ 2016-08-25 7:35 UTC (permalink / raw) To: Icenowy Zheng Cc: Russell King, Chen-Yu Tsai, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 5491 bytes --] On Thu, Aug 25, 2016 at 07:57:33AM +0800, Icenowy Zheng wrote: > > > 25.08.2016, 03:32, "Maxime Ripard" <maxime.ripard@free-electrons.com>: > > Hi, > > > > On Tue, Aug 23, 2016 at 02:44:50PM +0800, Icenowy Zheng wrote: > >> The inet-d978_rev2 is a pcb used in generic A33 based tablets. It features > >> volume buttons, micro-usb otg, headphone connector and a power button. > >> > >> On the board a Realtek RTL8723BS SDIO Wi-Fi module are soldered, and there > >> is also a accompanied board which has a Goodix GT9271 soldered. > >> > >> As this board is desired to create tablets with a Home key dealed by > >> GT9271, a LED is present at the front panel at the position of the > >> Home key. > >> > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > >> --- > >> arch/arm/boot/dts/Makefile | 1 + > >> arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 87 ++++++++++++++++++++++++++ > >> 2 files changed, 88 insertions(+) > >> create mode 100644 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >> index faacd52..d1812a0 100644 > >> --- a/arch/arm/boot/dts/Makefile > >> +++ b/arch/arm/boot/dts/Makefile > >> @@ -782,6 +782,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > >> sun8i-a23-q8-tablet.dtb \ > >> sun8i-a33-et-q8-v1.6.dtb \ > >> sun8i-a33-ga10h-v1.1.dtb \ > >> + sun8i-a33-inet-d978-rev2.dtb \ > >> sun8i-a33-ippo-q8h-v1.2.dtb \ > >> sun8i-a33-q8-tablet.dtb \ > >> sun8i-a33-sinlinx-sina33.dtb \ > >> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >> new file mode 100644 > >> index 0000000..78823d8 > >> --- /dev/null > >> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >> @@ -0,0 +1,87 @@ > >> +/* > >> + * Copyright 2015 Hans de Goede <hdegoede@redhat.com> > > > > I guess you are the author too :) > > > >> + * > >> + * This file is dual-licensed: you can use it either under the terms > >> + * of the GPL or the X11 license, at your option. Note that this dual > >> + * licensing only applies to this file, and not this project as a > >> + * whole. > >> + * > >> + * a) This file is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU General Public License as > >> + * published by the Free Software Foundation; either version 2 of the > >> + * License, or (at your option) any later version. > >> + * > >> + * This file is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + * > >> + * Or, alternatively, > >> + * > >> + * b) Permission is hereby granted, free of charge, to any person > >> + * obtaining a copy of this software and associated documentation > >> + * files (the "Software"), to deal in the Software without > >> + * restriction, including without limitation the rights to use, > >> + * copy, modify, merge, publish, distribute, sublicense, and/or > >> + * sell copies of the Software, and to permit persons to whom the > >> + * Software is furnished to do so, subject to the following > >> + * conditions: > >> + * > >> + * The above copyright notice and this permission notice shall be > >> + * included in all copies or substantial portions of the Software. > >> + * > >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > >> + * OTHER DEALINGS IN THE SOFTWARE. > >> + */ > >> + > >> +/dts-v1/; > >> +#include "sun8i-a33.dtsi" > >> +#include "sun8i-reference-design-tablet.dtsi" > >> + > >> +/ { > >> + model = "INet-D978 Rev 02"; > >> + compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; > >> + > >> + leds { > >> + compatible = "gpio-leds"; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&led_pin_d978>; > >> + > >> + home { > >> + label = "d978:home"; > > > > This is not the proper format for the led labels. > > > > It's supposed to be <board>:<color>:<function> > > Thanks. > So I'd use "d978:blue:home". > > > > >> + gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ > >> + }; > >> + }; > >> +}; > >> + > >> +&mmc1_pins_a { > >> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; > >> +}; > >> + > >> +&mmc1 { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&mmc1_pins_a>; > >> + vmmc-supply = <®_dldo1>; > >> + bus-width = <4>; > >> + non-removable; > >> + status = "okay"; > >> + > >> + rtl8723bs: sdio_wifi@1 { > >> + reg = <1>; > >> + }; > > > > Don't you need an alias to this node to have the MAC address set? > > It seems that rtl8723bs come with an eFUSE. Ok, good to know. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20160823064451.25997-3-icenowy@aosc.xyz>]
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <20160823064451.25997-3-icenowy@aosc.xyz> @ 2016-08-24 19:36 ` Maxime Ripard [not found] ` <43951472083107@web23m.yandex.ru> 0 siblings, 1 reply; 8+ messages in thread From: Maxime Ripard @ 2016-08-24 19:36 UTC (permalink / raw) To: Icenowy Zheng Cc: Russell King, Chen-Yu Tsai, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1292 bytes --] Hi, On Tue, Aug 23, 2016 at 02:44:51PM +0800, Icenowy Zheng wrote: > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card > on iNet D978 Rev2 board. > > Enable the UART1 to make it possible to use the modified hciattach by > Realtek to drive the BT part of RTL8723BS. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> I guess you could fold that patch into the previous one. > --- > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > index 78823d8..3ac22d4 100644 > --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > @@ -48,6 +48,10 @@ > model = "INet-D978 Rev 02"; > compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; > > + aliases { > + serial1 = &uart1; > + }; > + Is there any other UART in the system? The alias is not supposed to be about the controller index, but the index in the board, meaning that if you only have a single UART, that would be serial0. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <43951472083107@web23m.yandex.ru>]
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <43951472083107@web23m.yandex.ru> @ 2016-08-25 4:40 ` Chen-Yu Tsai [not found] ` <97321472108244@web8m.yandex.ru> 0 siblings, 1 reply; 8+ messages in thread From: Chen-Yu Tsai @ 2016-08-25 4:40 UTC (permalink / raw) To: Icenowy Zheng Cc: Maxime Ripard, Russell King, Chen-Yu Tsai, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel On Thu, Aug 25, 2016 at 7:58 AM, Icenowy Zheng <icenowy@aosc.xyz> wrote: > > > 25.08.2016, 03:36, "Maxime Ripard" <maxime.ripard@free-electrons.com>: >> Hi, >> >> On Tue, Aug 23, 2016 at 02:44:51PM +0800, Icenowy Zheng wrote: >>> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card >>> on iNet D978 Rev2 board. >>> >>> Enable the UART1 to make it possible to use the modified hciattach by >>> Realtek to drive the BT part of RTL8723BS. >>> >>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> >> >> I guess you could fold that patch into the previous one. >> >>> --- >>> arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> index 78823d8..3ac22d4 100644 >>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> @@ -48,6 +48,10 @@ >>> model = "INet-D978 Rev 02"; >>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; >>> >>> + aliases { >>> + serial1 = &uart1; >>> + }; >>> + >> >> Is there any other UART in the system? > > serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart. If your board does not have r_uart pads, then the right thing to do would be to disable it. You can then have uart1 as serial0. AFAIK Linux requires a console, but that console can be simplefb. ChenYu >> >> The alias is not supposed to be about the controller index, but the >> index in the board, meaning that if you only have a single UART, that >> would be serial0. >> >> Thanks! >> Maxime >> >> -- >> Maxime Ripard, Free Electrons >> Embedded Linux and Kernel engineering >> http://free-electrons.com ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <97321472108244@web8m.yandex.ru>]
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <97321472108244@web8m.yandex.ru> @ 2016-08-25 8:03 ` Maxime Ripard [not found] ` <116041472134355@web12g.yandex.ru> 0 siblings, 1 reply; 8+ messages in thread From: Maxime Ripard @ 2016-08-25 8:03 UTC (permalink / raw) To: Icenowy Zheng Cc: Chen-Yu Tsai, Russell King, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1328 bytes --] Hi, On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote: > >>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> index 78823d8..3ac22d4 100644 > >>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> @@ -48,6 +48,10 @@ > >>>> model = "INet-D978 Rev 02"; > >>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; > >>>> > >>>> + aliases { > >>>> + serial1 = &uart1; > >>>> + }; > >>>> + > >>> > >>> Is there any other UART in the system? > >> > >> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart. > > > > If your board does not have r_uart pads, then the right thing to do > > would be to disable it. You can then have uart1 as serial0. > > I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with > MMC) Then you don't support it and you need to disable it. > But many codes will require a ttyS0 as console... So I think the > bluetooth should be located at ttyS1... Most of them would use /dev/console anyway. What do you have in mind? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <116041472134355@web12g.yandex.ru>]
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <116041472134355@web12g.yandex.ru> @ 2016-08-25 14:17 ` Hans de Goede [not found] ` <438381472136802@web24g.yandex.ru> 2016-08-25 20:47 ` Maxime Ripard 1 sibling, 1 reply; 8+ messages in thread From: Hans de Goede @ 2016-08-25 14:17 UTC (permalink / raw) To: Icenowy Zheng, Maxime Ripard Cc: Chen-Yu Tsai, Russell King, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel Hi, On 25-08-16 16:12, Icenowy Zheng wrote: > > > 25.08.2016, 16:03, "Maxime Ripard" <maxime.ripard@free-electrons.com>: >> Hi, >> >> On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote: >>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> >>>> index 78823d8..3ac22d4 100644 >>> >>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> >>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>> >>>> @@ -48,6 +48,10 @@ >>> >>>> model = "INet-D978 Rev 02"; >>> >>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; >>> >>>> >>> >>>> + aliases { >>> >>>> + serial1 = &uart1; >>> >>>> + }; >>> >>>> + >>> >>> >>> >>> Is there any other UART in the system? >>> >> >>> >> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart. >>> > >>> > If your board does not have r_uart pads, then the right thing to do >>> > would be to disable it. You can then have uart1 as serial0. >>> >>> I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with >>> MMC) >> >> Then you don't support it and you need to disable it. >> >>> But many codes will require a ttyS0 as console... So I think the >>> bluetooth should be located at ttyS1... >> >> Most of them would use /dev/console anyway. What do you have in mind? > > As a general configuration, /dev/ttyS0 will be indicated as the default console= > value... (Otherwise more boards will fail) > > Or maybe we can specify uart0 as serial0, and leave it as disabled? (Thus if the > debug port is needed, we can easily apply a overlay with &mmc0 status as disabled, > and &uart0 status as okay) > > On all my A33 boards, the official boot0, u-boot all uses uart0 as debugging port. If no uart is available (and being muxed with the mmc counts as not being available) then you should not have any serial alias in the dts. In u-boot you need to use: # CONFIG_REQUIRE_SERIAL_CONSOLE is not set In the defconfig in this case, otherwise u-boot is going to be unhappy about not having a serial console. Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <438381472136802@web24g.yandex.ru>]
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <438381472136802@web24g.yandex.ru> @ 2016-08-25 15:13 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2016-08-25 15:13 UTC (permalink / raw) To: Icenowy Zheng, Maxime Ripard Cc: Chen-Yu Tsai, Russell King, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel HI, On 25-08-16 16:53, Icenowy Zheng wrote: > > > 25.08.2016, 22:18, "Hans de Goede" <hdegoede@redhat.com>: >> Hi, >> >> On 25-08-16 16:12, Icenowy Zheng wrote: >>> 25.08.2016, 16:03, "Maxime Ripard" <maxime.ripard@free-electrons.com>: >>>> Hi, >>>> >>>> On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote: >>>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>>>> >>>> index 78823d8..3ac22d4 100644 >>>>> >>>> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>>>> >>>> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts >>>>> >>>> @@ -48,6 +48,10 @@ >>>>> >>>> model = "INet-D978 Rev 02"; >>>>> >>>> compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33"; >>>>> >>>> >>>>> >>>> + aliases { >>>>> >>>> + serial1 = &uart1; >>>>> >>>> + }; >>>>> >>>> + >>>>> >>> >>>>> >>> Is there any other UART in the system? >>>>> >> >>>>> >> serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart. >>>>> > >>>>> > If your board does not have r_uart pads, then the right thing to do >>>>> > would be to disable it. You can then have uart1 as serial0. >>>>> >>>>> I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed with >>>>> MMC) >>>> >>>> Then you don't support it and you need to disable it. >>>> >>>>> But many codes will require a ttyS0 as console... So I think the >>>>> bluetooth should be located at ttyS1... >>>> >>>> Most of them would use /dev/console anyway. What do you have in mind? >>> >>> As a general configuration, /dev/ttyS0 will be indicated as the default console= >>> value... (Otherwise more boards will fail) >>> >>> Or maybe we can specify uart0 as serial0, and leave it as disabled? (Thus if the >>> debug port is needed, we can easily apply a overlay with &mmc0 status as disabled, >>> and &uart0 status as okay) >>> >>> On all my A33 boards, the official boot0, u-boot all uses uart0 as debugging port. >> >> If no uart is available (and being muxed with the mmc counts as not being available) >> then you should not have any serial alias in the dts. >> >> In u-boot you need to use: >> >> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set >> >> In the defconfig in this case, otherwise u-boot is going to be unhappy about >> not having a serial console. > > It's not the problem. > > Can I have no ttyS0 and just make bluetooth ttyS1? Ah, yes having a serial1 alias should do that I believe and I agree that it is probably better to not use ttyS0 for the bluetooth uart. Regards, Hans ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board [not found] ` <116041472134355@web12g.yandex.ru> 2016-08-25 14:17 ` Hans de Goede @ 2016-08-25 20:47 ` Maxime Ripard 1 sibling, 0 replies; 8+ messages in thread From: Maxime Ripard @ 2016-08-25 20:47 UTC (permalink / raw) To: Icenowy Zheng Cc: Chen-Yu Tsai, Russell King, Hans de Goede, Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 880 bytes --] On Thu, Aug 25, 2016 at 10:12:35PM +0800, Icenowy Zheng wrote: > >> But many codes will require a ttyS0 as console... So I think the > >> bluetooth should be located at ttyS1... > > > > Most of them would use /dev/console anyway. What do you have in mind? > > As a general configuration, /dev/ttyS0 will be indicated as the default console= > value... (Otherwise more boards will fail) There's no reason to make that assumption. The console might be on another UART entirely (ttyS3, for the sake of the argument), on a different UART "class" (ttyUSB?, framebuffer console?), or not present at all. If you want to use the console, use /dev/console. I don't what's so special about the UART here. Every single device in Linux behaves that way. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-08-25 20:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160823064451.25997-1-icenowy@aosc.xyz>
[not found] ` <20160823064451.25997-2-icenowy@aosc.xyz>
2016-08-24 19:32 ` [PATCH 1/2] ARM: dts: sun8i: Add dts file for inet-d978_rev2 tablets Maxime Ripard
[not found] ` <43601472083053@web23m.yandex.ru>
2016-08-25 7:35 ` Maxime Ripard
[not found] ` <20160823064451.25997-3-icenowy@aosc.xyz>
2016-08-24 19:36 ` [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Maxime Ripard
[not found] ` <43951472083107@web23m.yandex.ru>
2016-08-25 4:40 ` Chen-Yu Tsai
[not found] ` <97321472108244@web8m.yandex.ru>
2016-08-25 8:03 ` Maxime Ripard
[not found] ` <116041472134355@web12g.yandex.ru>
2016-08-25 14:17 ` Hans de Goede
[not found] ` <438381472136802@web24g.yandex.ru>
2016-08-25 15:13 ` Hans de Goede
2016-08-25 20:47 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).