* [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()
@ 2017-06-22 22:41 Gustavo A. R. Silva
2017-06-23 8:06 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-22 22:41 UTC (permalink / raw)
To: Jason Wessel; +Cc: kgdb-bugreport, linux-kernel, Gustavo A. R. Silva
Value assigned to variable _bp_ at line 415 is the same as at line 434.
This makes such variable assignment unnecessary.
Addresses-Coverity-ID: 1227025
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
kernel/debug/kdb/kdb_bp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
index 90ff129..039a329e 100644
--- a/kernel/debug/kdb/kdb_bp.c
+++ b/kernel/debug/kdb/kdb_bp.c
@@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
* assume that the breakpoint number is desired.
*/
if (addr < KDB_MAXBPT) {
- bp = &kdb_breakpoints[addr];
lowbp = highbp = addr;
highbp++;
} else {
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()
2017-06-22 22:41 [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() Gustavo A. R. Silva
@ 2017-06-23 8:06 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2017-06-23 8:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jason Wessel; +Cc: kgdb-bugreport, linux-kernel
On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
>
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> kernel/debug/kdb/kdb_bp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
> * assume that the breakpoint number is desired.
> */
> if (addr < KDB_MAXBPT) {
> - bp = &kdb_breakpoints[addr];
> lowbp = highbp = addr;
> highbp++;
> } else {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-23 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 22:41 [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() Gustavo A. R. Silva
2017-06-23 8:06 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).