From: Konrad Dybcio <konradybcio@gmail.com>
To: Amit Pundir <amit.pundir@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)
Date: Fri, 21 Aug 2020 23:21:25 +0200 [thread overview]
Message-ID: <23c4191e-4d64-80d8-e688-27d004729ea1@gmail.com> (raw)
In-Reply-To: <1598029961-2474-1-git-send-email-amit.pundir@linaro.org>
Hi
First of all, sorry if anybody sees this twice. I've been messing with Thunderbird lately.
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-beryllium.dtb
[B]eryllium should come before [C]heza, no? Also, aren't the non-development boards supposed to include the vendor name? i.e. sdm845-(xiaomi/poco)-beryllium.dtb
> + model = "Xiaomi Technologies Inc. Beryllium";
At least with Xperias, we settled on setting the model property to the "pretty" name, in this case Poco F1
> + pm8998-rpmh-regulators {
> + compatible = "qcom,pm8998-rpmh-regulators";
> + qcom,pmic-id = "a";
> +
> + vreg_l1a_0p875: ldo1 {
I think you forgot to include (regulatorname)-supply properties which should cause havoc with all things regulators..
> + vreg_l1a_0p875: ldo1 {
> + regulator-min-microvolt = <880000>;
> + regulator-max-microvolt = <880000>;
0p88? Unless it's a PMIC limitation.. Please also confirm names for the rest of the regulators.
Also why are there so few regulators? And none from pmi8998? Are the rest WIP/coming in a followup commit, or are they disabled on this board? AFAICS you only include SoC/PMIC DTs which would suggest they should be there.
> +/* Reserved memory changes from downstream */
Wouldn't it look better if you included that in the main {} node instead of reopening it in the middle of the file? I mean, it works, but let's hear what others have to say.
> + * It seems that mmc_test reports errors if drive
> + * strength is not 16 on clk, cmd, and data pins.
You say that, but then you set "drive-strength = <10>;" for cmd and data, please confirm it's intentional.
> +&ufs_mem_hc {
UFS comes before USB alphabetically.
> +&ufs_mem_phy
Ditto
> +&qup_uart6_default
Ditto
Konrad
next prev parent reply other threads:[~2020-08-21 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 17:12 [PATCH v5] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium) Amit Pundir
2020-08-21 21:21 ` Konrad Dybcio [this message]
2020-08-25 13:31 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23c4191e-4d64-80d8-e688-27d004729ea1@gmail.com \
--to=konradybcio@gmail.com \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).