* [PATCH] vdso/datapage: use correct clock mode name in comment
@ 2020-04-20 10:06 Christian Brauner
2020-04-20 11:17 ` Vincenzo Frascino
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christian Brauner @ 2020-04-20 10:06 UTC (permalink / raw)
To: Andy Lutomirski, Thomas Gleixner, Vincenzo Frascino, linux-kernel
Cc: Dmitry Safonov, Andrei Vagin, Christian Brauner, Dmitry Safonov
While the explanation for time namespace <-> vdso interactions is very
helpful it uses the wrong name in the comment when describing the clock
mode making grepping a bit annoying.
This seems like an accidental oversight when moving from VCLOCK_TIMENS
to VDSO_CLOCKMODE_TIMENS. It seems that
660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
Update the commit to use VDSO_CLOCKMODE_TIMENS.
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dmitry Safonov <dima@arista.com>
Cc: Andrei Vagin <avagin@gmail.com>
Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---
include/vdso/datapage.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
index 5cbc9fcbfd45..7955c56d6b3c 100644
--- a/include/vdso/datapage.h
+++ b/include/vdso/datapage.h
@@ -73,8 +73,8 @@ struct vdso_timestamp {
*
* @offset is used by the special time namespace VVAR pages which are
* installed instead of the real VVAR page. These namespace pages must set
- * @seq to 1 and @clock_mode to VLOCK_TIMENS to force the code into the
- * time namespace slow path. The namespace aware functions retrieve the
+ * @seq to 1 and @clock_mode to VDSO_CLOCKMODE_TIMENS to force the code into
+ * the time namespace slow path. The namespace aware functions retrieve the
* real system wide VVAR page, read host time and add the per clock offset.
* For clocks which are not affected by time namespace adjustment the
* offset must be zero.
base-commit: ae83d0b416db002fe95601e7f97f64b59514d936
--
2.26.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vdso/datapage: use correct clock mode name in comment
2020-04-20 10:06 [PATCH] vdso/datapage: use correct clock mode name in comment Christian Brauner
@ 2020-04-20 11:17 ` Vincenzo Frascino
2020-04-20 16:03 ` Andrei Vagin
2020-04-20 17:27 ` [tip: timers/urgent] vdso/datapage: Use " tip-bot2 for Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: Vincenzo Frascino @ 2020-04-20 11:17 UTC (permalink / raw)
To: Christian Brauner, Andy Lutomirski, Thomas Gleixner, linux-kernel
Cc: Dmitry Safonov, Andrei Vagin, Dmitry Safonov
On 4/20/20 11:06 AM, Christian Brauner wrote:
> While the explanation for time namespace <-> vdso interactions is very
> helpful it uses the wrong name in the comment when describing the clock
> mode making grepping a bit annoying.
>
> This seems like an accidental oversight when moving from VCLOCK_TIMENS
> to VDSO_CLOCKMODE_TIMENS. It seems that
> 660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
> VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
> VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
> 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
>
> Update the commit to use VDSO_CLOCKMODE_TIMENS.
>
Probably you want to add that this patch adds no functional changes, just to
make it explicit.
Otherwise:
Acked-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Dmitry Safonov <dima@arista.com>
> Cc: Andrei Vagin <avagin@gmail.com>
> Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
> Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> include/vdso/datapage.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index 5cbc9fcbfd45..7955c56d6b3c 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -73,8 +73,8 @@ struct vdso_timestamp {
> *
> * @offset is used by the special time namespace VVAR pages which are
> * installed instead of the real VVAR page. These namespace pages must set
> - * @seq to 1 and @clock_mode to VLOCK_TIMENS to force the code into the
> - * time namespace slow path. The namespace aware functions retrieve the
> + * @seq to 1 and @clock_mode to VDSO_CLOCKMODE_TIMENS to force the code into
> + * the time namespace slow path. The namespace aware functions retrieve the
> * real system wide VVAR page, read host time and add the per clock offset.
> * For clocks which are not affected by time namespace adjustment the
> * offset must be zero.
>
> base-commit: ae83d0b416db002fe95601e7f97f64b59514d936
>
--
Regards,
Vincenzo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vdso/datapage: use correct clock mode name in comment
2020-04-20 10:06 [PATCH] vdso/datapage: use correct clock mode name in comment Christian Brauner
2020-04-20 11:17 ` Vincenzo Frascino
@ 2020-04-20 16:03 ` Andrei Vagin
2020-04-20 17:27 ` [tip: timers/urgent] vdso/datapage: Use " tip-bot2 for Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: Andrei Vagin @ 2020-04-20 16:03 UTC (permalink / raw)
To: Christian Brauner
Cc: Andy Lutomirski, Thomas Gleixner, Vincenzo Frascino,
linux-kernel, Dmitry Safonov, Dmitry Safonov
On Mon, Apr 20, 2020 at 12:06:15PM +0200, Christian Brauner wrote:
> While the explanation for time namespace <-> vdso interactions is very
> helpful it uses the wrong name in the comment when describing the clock
> mode making grepping a bit annoying.
>
> This seems like an accidental oversight when moving from VCLOCK_TIMENS
> to VDSO_CLOCKMODE_TIMENS. It seems that
> 660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
> VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
> VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
> 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
>
> Update the commit to use VDSO_CLOCKMODE_TIMENS.
>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Dmitry Safonov <dima@arista.com>
> Cc: Andrei Vagin <avagin@gmail.com>
> Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
> Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Acked-by: Andrei Vagin <avagin@gmail.com>
Thanks,
Andrei
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: timers/urgent] vdso/datapage: Use correct clock mode name in comment
2020-04-20 10:06 [PATCH] vdso/datapage: use correct clock mode name in comment Christian Brauner
2020-04-20 11:17 ` Vincenzo Frascino
2020-04-20 16:03 ` Andrei Vagin
@ 2020-04-20 17:27 ` tip-bot2 for Christian Brauner
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Christian Brauner @ 2020-04-20 17:27 UTC (permalink / raw)
To: linux-tip-commits
Cc: Christian Brauner, Thomas Gleixner, Andrei Vagin,
Vincenzo Frascino, x86, LKML
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: ac84bac4062e7fc24f5e2c61c6a414b2a00a29ad
Gitweb: https://git.kernel.org/tip/ac84bac4062e7fc24f5e2c61c6a414b2a00a29ad
Author: Christian Brauner <christian.brauner@ubuntu.com>
AuthorDate: Mon, 20 Apr 2020 12:06:15 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 20 Apr 2020 19:19:52 +02:00
vdso/datapage: Use correct clock mode name in comment
While the explanation for time namespace <-> vdso interactions is very
helpful it uses the wrong name in the comment when describing the clock
mode making grepping a bit annoying.
This seems like an accidental oversight when moving from VCLOCK_TIMENS
to VDSO_CLOCKMODE_TIMENS. It seems that
660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
Update the comment to use VDSO_CLOCKMODE_TIMENS.
Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Andrei Vagin <avagin@gmail.com>
Acked-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lkml.kernel.org/r/20200420100615.1549804-1-christian.brauner@ubuntu.com
---
include/vdso/datapage.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
index 5cbc9fc..7955c56 100644
--- a/include/vdso/datapage.h
+++ b/include/vdso/datapage.h
@@ -73,8 +73,8 @@ struct vdso_timestamp {
*
* @offset is used by the special time namespace VVAR pages which are
* installed instead of the real VVAR page. These namespace pages must set
- * @seq to 1 and @clock_mode to VLOCK_TIMENS to force the code into the
- * time namespace slow path. The namespace aware functions retrieve the
+ * @seq to 1 and @clock_mode to VDSO_CLOCKMODE_TIMENS to force the code into
+ * the time namespace slow path. The namespace aware functions retrieve the
* real system wide VVAR page, read host time and add the per clock offset.
* For clocks which are not affected by time namespace adjustment the
* offset must be zero.
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-20 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 10:06 [PATCH] vdso/datapage: use correct clock mode name in comment Christian Brauner
2020-04-20 11:17 ` Vincenzo Frascino
2020-04-20 16:03 ` Andrei Vagin
2020-04-20 17:27 ` [tip: timers/urgent] vdso/datapage: Use " tip-bot2 for Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).