[PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

[PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

[Thomas Huth]

The vfio_ap module tries to register for the vfio_ap bus - but that's
the interface that it provides itself, so this does not make much sense,
thus let's simply drop this statement now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 See also my previous patch to register it for the "ap" bus instead:
 https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
 ... but since it has been decided to not auto-load the module uncondi-
 tionally, I'd like to suggest to rather drop this line now instead.

 drivers/s390/crypto/vfio_ap_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 29ebd54f8919..4ac9c6521ec1 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = {
 	{ /* end of sibling */ },
 };
 
-MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
-
 static struct ap_matrix_mdev *vfio_ap_mdev_for_queue(struct vfio_ap_queue *q)
 {
 	struct ap_matrix_mdev *matrix_mdev;
-- 
2.27.0

Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

[Tony Krowiak]

Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>

On 4/13/22 5:44 AM, Thomas Huth wrote:
> The vfio_ap module tries to register for the vfio_ap bus - but that's
> the interface that it provides itself, so this does not make much sense,
> thus let's simply drop this statement now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   See also my previous patch to register it for the "ap" bus instead:
>   https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
>   ... but since it has been decided to not auto-load the module uncondi-
>   tionally, I'd like to suggest to rather drop this line now instead.
>
>   drivers/s390/crypto/vfio_ap_drv.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 29ebd54f8919..4ac9c6521ec1 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = {
>   	{ /* end of sibling */ },
>   };
>   
> -MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
> -
>   static struct ap_matrix_mdev *vfio_ap_mdev_for_queue(struct vfio_ap_queue *q)
>   {
>   	struct ap_matrix_mdev *matrix_mdev;

Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

[Heiko Carstens]

On Mon, Apr 18, 2022 at 10:23:38AM -0400, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
> 
> On 4/13/22 5:44 AM, Thomas Huth wrote:
> > The vfio_ap module tries to register for the vfio_ap bus - but that's
> > the interface that it provides itself, so this does not make much sense,
> > thus let's simply drop this statement now.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   See also my previous patch to register it for the "ap" bus instead:
> >   https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
> >   ... but since it has been decided to not auto-load the module uncondi-
> >   tionally, I'd like to suggest to rather drop this line now instead.
> > 
> >   drivers/s390/crypto/vfio_ap_drv.c | 2 --
> >   1 file changed, 2 deletions(-)

...

Applied, thanks.