linux-next: build warnings after merge of Linus' tree

linux-next: build warnings after merge of Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Hi all,

While building Linus' tree, today's linux-next build (htmldocs)
produced these warnings:

kernel/sched/core.c:11496: warning: Cannot understand  * @cid_lock: Guarantee forward-progress of cid allocation.
 on line 11496 - I thought it was a doc line
kernel/sched/core.c:11505: warning: Cannot understand  * @use_cid_lock: Select cid allocation behavior: lock-free vs spinlock.
 on line 11505 - I thought it was a doc line

Introduced by commit

  223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of Linus' tree

[Randy Dunlap]

On 5/7/23 21:49, Stephen Rothwell wrote:
> Hi all,
> 
> While building Linus' tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> kernel/sched/core.c:11496: warning: Cannot understand  * @cid_lock: Guarantee forward-progress of cid allocation.
>  on line 11496 - I thought it was a doc line
> kernel/sched/core.c:11505: warning: Cannot understand  * @use_cid_lock: Select cid allocation behavior: lock-free vs spinlock.
>  on line 11505 - I thought it was a doc line
> 
> Introduced by commit
> 
>   223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")
> 

I have sent a patch:
  https://lore.kernel.org/lkml/20230428031111.322-1-rdunlap@infradead.org
but haven't seen any replies to it (possibly due to the merge window or travel).

-- 
~Randy

Re: linux-next: build warnings after merge of Linus' tree

[Randy Dunlap]

On 5/7/23 21:52, Randy Dunlap wrote:
> 
> 
> On 5/7/23 21:49, Stephen Rothwell wrote:
>> Hi all,
>>
>> While building Linus' tree, today's linux-next build (htmldocs)
>> produced these warnings:
>>
>> kernel/sched/core.c:11496: warning: Cannot understand  * @cid_lock: Guarantee forward-progress of cid allocation.
>>  on line 11496 - I thought it was a doc line
>> kernel/sched/core.c:11505: warning: Cannot understand  * @use_cid_lock: Select cid allocation behavior: lock-free vs spinlock.
>>  on line 11505 - I thought it was a doc line
>>
>> Introduced by commit
>>
>>   223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")
>>
> 
> I have sent a patch:
>   https://lore.kernel.org/lkml/20230428031111.322-1-rdunlap@infradead.org
> but haven't seen any replies to it (possibly due to the merge window or travel).
> 

Oops, Peter did reply, but no info on merging it.

-- 
~Randy

Re: linux-next: build warnings after merge of Linus' tree

[Peter Zijlstra]

On Sun, May 07, 2023 at 09:52:22PM -0700, Randy Dunlap wrote:
> 
> 
> On 5/7/23 21:49, Stephen Rothwell wrote:
> > Hi all,
> > 
> > While building Linus' tree, today's linux-next build (htmldocs)
> > produced these warnings:
> > 
> > kernel/sched/core.c:11496: warning: Cannot understand  * @cid_lock: Guarantee forward-progress of cid allocation.
> >  on line 11496 - I thought it was a doc line
> > kernel/sched/core.c:11505: warning: Cannot understand  * @use_cid_lock: Select cid allocation behavior: lock-free vs spinlock.
> >  on line 11505 - I thought it was a doc line
> > 
> > Introduced by commit
> > 
> >   223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")
> > 
> 
> I have sent a patch:
>   https://lore.kernel.org/lkml/20230428031111.322-1-rdunlap@infradead.org
> but haven't seen any replies to it (possibly due to the merge window or travel).

I have it, and now that -rc1 is out the door, I'll queue it for -urgent.

linux-next: build warnings after merge of Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi all,

After merging Linus' tree, today's linux-next build (htmldocs) produced
these warnings:

include/linux/of.h:1211: warning: Function parameter or member 'output' not described in 'of_property_read_string_index'
include/linux/of.h:1211: warning: Excess function parameter 'out_string' description in 'of_property_read_string_index'

Introduced by commit

  a87fa1d81a9f ("of: Fix overflow bug in string property parsing functions")

include/linux/of.h:1480: warning: cannot understand function prototype: 'enum of_overlay_notify_action '

Introduced by commit

  39a842e22c1b ("of/overlay: add of overlay notifications")

I assume that these warnings have turned up now due to better(?) tooling.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of Linus' tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Hi all,

On Mon, 29 Mar 2021 20:04:10 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging Linus' tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> include/linux/of.h:1211: warning: Function parameter or member 'output' not described in 'of_property_read_string_index'
> include/linux/of.h:1211: warning: Excess function parameter 'out_string' description in 'of_property_read_string_index'
> 
> Introduced by commit
> 
>   a87fa1d81a9f ("of: Fix overflow bug in string property parsing functions")
> 
> I assume that these warnings have turned up now due to better(?) tooling.

I am still seeing these warnings (as of next-20210420).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of Linus' tree

[Rob Herring]

On Wed, Apr 21, 2021 at 1:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 29 Mar 2021 20:04:10 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging Linus' tree, today's linux-next build (htmldocs) produced
> > these warnings:
> >
> > include/linux/of.h:1211: warning: Function parameter or member 'output' not described in 'of_property_read_string_index'
> > include/linux/of.h:1211: warning: Excess function parameter 'out_string' description in 'of_property_read_string_index'
> >
> > Introduced by commit
> >
> >   a87fa1d81a9f ("of: Fix overflow bug in string property parsing functions")
> >
> > I assume that these warnings have turned up now due to better(?) tooling.
>
> I am still seeing these warnings (as of next-20210420).

A fix is now in my tree.

Rob