From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
Date: Thu, 16 Nov 2017 20:30:24 +0100 [thread overview]
Message-ID: <24f8c777-1eb4-e7e7-9371-79f32700c9dc@users.sourceforge.net> (raw)
In-Reply-To: <s5h7euq9hqt.wl-tiwai@suse.de>
>> There is a general source code transformation pattern involved.
>> So I find that it is systematic.
>>
>> But I did not dare to develop a script variant for the semantic patch
>> language (Coccinelle software) which can handle all special use cases
>> as a few of them are already demonstrated in this tiny patch series.
>
> Then you're doing everything by hands,
I am navigating through possible changes around the pattern
“Use common error handling code” mostly manually so far.
> and can be wrong
Such a possibility remains as usual.
> -- that's the heart of the problem.
There might be related opportunities for further improvements.
Do you trust adjustments from an evolving tool more than
my concrete contributions?
> The risk is bigger than the merit by applying the patch.
I suggest to reconsider this view.
Would you dare to follow any of the presented arguments?
> So, just prove that your patch doesn't break anything.
Which kind of information would you find sufficient for a “prove”?
> Doesn't matter whether it's a test with real hardware
> or with systematic checks.
I assume that your development concerns matter more in this case.
> Once when it's confirmed, we can apply it.
I am curious if other contributors will become interested to confirm something.
> A very simple rule,
It might occasionally look simpler than it is in “special cases”.
> and this will be valid for most of other subsystems, too.
The response is also varying there as usual.
A few update suggestions from the discussed pattern were integrated
(also by you) already.
Would you like to continue with similar support in any ways?
Regards,
Markus
next prev parent reply other threads:[~2017-11-16 19:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:05 [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations SF Markus Elfring
2017-11-16 17:07 ` [PATCH 1/2] ALSA: nm256: Adjust five function calls together with a variable assignment SF Markus Elfring
2017-11-16 17:08 ` [PATCH 2/2] ALSA: nm256: Use common error handling code in snd_nm256_probe() SF Markus Elfring
2017-11-16 17:15 ` [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations Takashi Iwai
2017-11-16 17:48 ` SF Markus Elfring
2017-11-16 18:54 ` Takashi Iwai
2017-11-16 19:30 ` SF Markus Elfring [this message]
2017-11-28 7:46 ` Takashi Iwai
2017-11-28 8:19 ` SF Markus Elfring
2017-11-28 9:10 ` Takashi Iwai
2017-11-28 9:50 ` SF Markus Elfring
2017-11-28 11:37 ` Takashi Iwai
2017-11-28 12:33 ` SF Markus Elfring
2017-11-28 12:46 ` Takashi Iwai
2017-11-28 13:00 ` SF Markus Elfring
2017-11-28 13:06 ` Takashi Iwai
2017-11-28 13:17 ` SF Markus Elfring
2017-11-28 13:38 ` Takashi Iwai
2017-11-28 14:19 ` SF Markus Elfring
2017-11-28 14:27 ` Takashi Iwai
2017-11-28 14:33 ` SF Markus Elfring
2017-11-28 14:38 ` Takashi Iwai
2017-11-28 14:44 ` SF Markus Elfring
2017-11-28 14:53 ` Takashi Iwai
2017-11-28 15:01 ` SF Markus Elfring
2017-11-28 15:21 ` Takashi Iwai
2017-11-28 16:15 ` SF Markus Elfring
2017-11-28 16:27 ` Takashi Iwai
2017-11-28 16:40 ` SF Markus Elfring
2017-11-28 16:44 ` Takashi Iwai
2017-11-28 17:15 ` SF Markus Elfring
2017-11-28 18:35 ` Takashi Iwai
2017-11-28 19:08 ` SF Markus Elfring
2017-11-28 19:43 ` Takashi Iwai
2017-11-28 19:48 ` SF Markus Elfring
2017-11-28 19:54 ` Takashi Iwai
2017-11-28 19:57 ` SF Markus Elfring
2017-11-28 20:00 ` Takashi Iwai
2017-11-28 20:18 ` SF Markus Elfring
2017-11-28 20:25 ` Takashi Iwai
2017-11-28 20:32 ` SF Markus Elfring
2017-11-29 10:34 ` SF Markus Elfring
2017-11-28 12:33 ` [alsa-devel] " Ondrej Zary
2017-11-28 13:10 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f8c777-1eb4-e7e7-9371-79f32700c9dc@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).