From: Takashi Iwai <tiwai@suse.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: alsa-devel@alsa-project.org,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations
Date: Tue, 28 Nov 2017 20:43:45 +0100 [thread overview]
Message-ID: <s5hk1yajij2.wl-tiwai@suse.de> (raw)
In-Reply-To: <19724fa4-47eb-827c-cb17-126440500179@users.sourceforge.net>
On Tue, 28 Nov 2017 20:08:13 +0100,
SF Markus Elfring wrote:
>
> >> Examples:
> >> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe()
> >> https://lkml.org/lkml/2017/11/18/266
> >> https://patchwork.kernel.org/patch/10064945/
> >> https://lkml.kernel.org/r/<a2cb6494-a01c-668a-cd9b-1a8428a0d4c9@users.sourceforge.net>
> >
> > This is no trivial patch.
>
> Why do you find this one more challenging now than a similar one?
>
> ALSA: maestro3: Use common error handling code in two functions
> https://lkml.org/lkml/2017/9/6/39
> https://patchwork.kernel.org/patch/9939985/
> https://lkml.kernel.org/r/<83b1ba49-253d-72ed-b3b0-ec7d5e72a12c@users.sourceforge.net>
Because it turned out that your patch can be wrong and broken.
Takashi
next prev parent reply other threads:[~2017-11-28 19:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:05 [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations SF Markus Elfring
2017-11-16 17:07 ` [PATCH 1/2] ALSA: nm256: Adjust five function calls together with a variable assignment SF Markus Elfring
2017-11-16 17:08 ` [PATCH 2/2] ALSA: nm256: Use common error handling code in snd_nm256_probe() SF Markus Elfring
2017-11-16 17:15 ` [PATCH 0/2] ALSA: nm256: Fine-tuning for three function implementations Takashi Iwai
2017-11-16 17:48 ` SF Markus Elfring
2017-11-16 18:54 ` Takashi Iwai
2017-11-16 19:30 ` SF Markus Elfring
2017-11-28 7:46 ` Takashi Iwai
2017-11-28 8:19 ` SF Markus Elfring
2017-11-28 9:10 ` Takashi Iwai
2017-11-28 9:50 ` SF Markus Elfring
2017-11-28 11:37 ` Takashi Iwai
2017-11-28 12:33 ` SF Markus Elfring
2017-11-28 12:46 ` Takashi Iwai
2017-11-28 13:00 ` SF Markus Elfring
2017-11-28 13:06 ` Takashi Iwai
2017-11-28 13:17 ` SF Markus Elfring
2017-11-28 13:38 ` Takashi Iwai
2017-11-28 14:19 ` SF Markus Elfring
2017-11-28 14:27 ` Takashi Iwai
2017-11-28 14:33 ` SF Markus Elfring
2017-11-28 14:38 ` Takashi Iwai
2017-11-28 14:44 ` SF Markus Elfring
2017-11-28 14:53 ` Takashi Iwai
2017-11-28 15:01 ` SF Markus Elfring
2017-11-28 15:21 ` Takashi Iwai
2017-11-28 16:15 ` SF Markus Elfring
2017-11-28 16:27 ` Takashi Iwai
2017-11-28 16:40 ` SF Markus Elfring
2017-11-28 16:44 ` Takashi Iwai
2017-11-28 17:15 ` SF Markus Elfring
2017-11-28 18:35 ` Takashi Iwai
2017-11-28 19:08 ` SF Markus Elfring
2017-11-28 19:43 ` Takashi Iwai [this message]
2017-11-28 19:48 ` SF Markus Elfring
2017-11-28 19:54 ` Takashi Iwai
2017-11-28 19:57 ` SF Markus Elfring
2017-11-28 20:00 ` Takashi Iwai
2017-11-28 20:18 ` SF Markus Elfring
2017-11-28 20:25 ` Takashi Iwai
2017-11-28 20:32 ` SF Markus Elfring
2017-11-29 10:34 ` SF Markus Elfring
2017-11-28 12:33 ` [alsa-devel] " Ondrej Zary
2017-11-28 13:10 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk1yajij2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).