From: John Hubbard <jhubbard@nvidia.com>
To: <paulmck@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
John Dias <joaodias@google.com>,
"David Hildenbrand" <david@redhat.com>
Subject: Re: [PATCH v4] mm: fix is_pinnable_page against on cma page
Date: Wed, 11 May 2022 18:02:03 -0700 [thread overview]
Message-ID: <2542a1be-f7dc-de2f-51cd-28a1ed5c3bda@nvidia.com> (raw)
In-Reply-To: <20220512004949.GK1790663@paulmck-ThinkPad-P17-Gen-1>
On 5/11/22 17:49, Paul E. McKenney wrote:
>> Thanks Paul for explaining the state of things.
>>
>> Minchan, how about something like very close to your original draft,
>> then, but with a little note, and the "&" as well:
>>
>> int __mt = get_pageblock_migratetype(page);
>>
>> /*
>> * Defend against future compiler LTO features, or code refactoring
>> * that inlines the above function, by forcing a single read. Because, this
>> * routine races with set_pageblock_migratetype(), and we want to avoid
>> * reading zero, when actually one or the other flags was set.
>> */
>> int mt = __READ_ONCE(__mt);
>>
>> if (mt & (MIGRATE_CMA | MIGRATE_ISOLATE))
>> return false;
>>
>>
>> ...which should make everyone comfortable and protected from the
>> future sins of the compiler and linker teams? :)
>
> This would work, but it would force a store to the stack and an immediate
> reload. Which might be OK on this code path.
>
> But using READ_ONCE() in (I think?) __get_pfnblock_flags_mask()
> would likely generate the same code that is produced today.
>
> word = READ_ONCE(bitmap[word_bitidx]);
Ah right, I like that much, much better. The READ_ONCE is placed where
it actually clearly matters, rather than several layers removed.
>
> But I could easily have missed a turn in that cascade of functions. ;-)
>
> Or there might be some code path that really hates a READ_ONCE() in
> that place.
I certainly hope not. I see free_one_page(), among other things, calls
this. But having the correct READ_ONCE() in a central place seems worth
it, unless we know that this will cause a measurable slowdown somewhere.
thanks,
--
John Hubbard
NVIDIA
>
> Thanx, Paul
next prev parent reply other threads:[~2022-05-12 1:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 21:17 [PATCH v4] mm: fix is_pinnable_page against on cma page Minchan Kim
2022-05-10 22:56 ` John Hubbard
2022-05-10 23:31 ` Minchan Kim
2022-05-10 23:58 ` John Hubbard
2022-05-11 0:09 ` Minchan Kim
2022-05-11 4:32 ` John Hubbard
2022-05-11 21:46 ` Minchan Kim
2022-05-11 22:25 ` John Hubbard
2022-05-11 22:37 ` Minchan Kim
2022-05-11 22:49 ` John Hubbard
2022-05-11 23:08 ` Minchan Kim
2022-05-11 23:13 ` John Hubbard
2022-05-11 23:15 ` Minchan Kim
2022-05-11 23:28 ` Minchan Kim
2022-05-11 23:33 ` John Hubbard
2022-05-11 23:45 ` Paul E. McKenney
2022-05-11 23:57 ` John Hubbard
2022-05-12 0:12 ` Paul E. McKenney
2022-05-12 0:12 ` John Hubbard
2022-05-12 0:22 ` Paul E. McKenney
2022-05-12 0:26 ` Minchan Kim
2022-05-12 0:34 ` John Hubbard
2022-05-12 0:49 ` Paul E. McKenney
2022-05-12 1:02 ` John Hubbard [this message]
2022-05-12 1:03 ` Minchan Kim
2022-05-12 1:08 ` John Hubbard
2022-05-12 2:18 ` John Hubbard
2022-05-12 3:44 ` Minchan Kim
2022-05-12 4:47 ` John Hubbard
2022-05-17 14:00 ` Jason Gunthorpe
2022-05-17 18:12 ` John Hubbard
2022-05-17 19:28 ` Jason Gunthorpe
2022-05-17 20:12 ` John Hubbard
2022-05-17 20:21 ` Paul E. McKenney
2022-05-23 16:33 ` Minchan Kim
2022-05-24 2:55 ` John Hubbard
2022-05-24 5:16 ` Minchan Kim
2022-05-24 6:22 ` John Hubbard
2022-05-24 14:19 ` Jason Gunthorpe
2022-05-24 15:43 ` Minchan Kim
2022-05-24 15:48 ` Jason Gunthorpe
2022-05-24 16:37 ` Paul E. McKenney
2022-05-24 16:59 ` Minchan Kim
2022-05-12 3:57 ` Paul E. McKenney
2022-05-12 1:03 ` Minchan Kim
2022-05-12 0:35 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2542a1be-f7dc-de2f-51cd-28a1ed5c3bda@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).