* [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>
@ 2022-05-02 12:37 Geert Uytterhoeven
2022-05-02 12:37 ` [PATCH 2/2] serial: 8250: pxa: " Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-05-02 12:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko, Peter Hurley,
Heikki Krogerus, Robert Jarzmik
Cc: linux-serial, linux-kernel, Geert Uytterhoeven
The last calls into Runtime PM were moved to 8250_port.c a long time
ago.
Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/8250/8250_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -32,7 +32,6 @@
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
-#include <linux/pm_runtime.h>
#include <linux/io.h>
#ifdef CONFIG_SPARC
#include <linux/sunserialcore.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] serial: 8250: pxa: Remove unneeded <linux/pm_runtime.h>
2022-05-02 12:37 [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h> Geert Uytterhoeven
@ 2022-05-02 12:37 ` Geert Uytterhoeven
2022-05-03 9:56 ` [PATCH 1/2] serial: 8250: core: " Andy Shevchenko
2022-05-03 12:24 ` Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-05-02 12:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko, Peter Hurley,
Heikki Krogerus, Robert Jarzmik
Cc: linux-serial, linux-kernel, Geert Uytterhoeven
The 8250 PXA driver never used Runtime PM, so there was never a need to
include <linux/pm_runtime.h>.
Fixes: ab28f51c77cd4618 ("serial: rewrite pxa2xx-uart to use 8250_core")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/8250/8250_pxa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_pxa.c b/drivers/tty/serial/8250/8250_pxa.c
index 33ca98bfa5b37c1b..795e55142d4c7c06 100644
--- a/drivers/tty/serial/8250/8250_pxa.c
+++ b/drivers/tty/serial/8250/8250_pxa.c
@@ -22,7 +22,6 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/clk.h>
-#include <linux/pm_runtime.h>
#include "8250.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>
2022-05-02 12:37 [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h> Geert Uytterhoeven
2022-05-02 12:37 ` [PATCH 2/2] serial: 8250: pxa: " Geert Uytterhoeven
@ 2022-05-03 9:56 ` Andy Shevchenko
2022-05-03 12:24 ` Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-05-03 9:56 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, Peter Hurley, Heikki Krogerus,
Robert Jarzmik, linux-serial, linux-kernel
On Mon, May 02, 2022 at 02:37:05PM +0200, Geert Uytterhoeven wrote:
> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.
Both
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> #include <linux/sunserialcore.h>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>
2022-05-02 12:37 [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h> Geert Uytterhoeven
2022-05-02 12:37 ` [PATCH 2/2] serial: 8250: pxa: " Geert Uytterhoeven
2022-05-03 9:56 ` [PATCH 1/2] serial: 8250: core: " Andy Shevchenko
@ 2022-05-03 12:24 ` Ilpo Järvinen
2 siblings, 0 replies; 4+ messages in thread
From: Ilpo Järvinen @ 2022-05-03 12:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, Andy Shevchenko, Peter Hurley,
Heikki Krogerus, Robert Jarzmik, linux-serial, LKML
On Mon, 2 May 2022, Geert Uytterhoeven wrote:
> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.
>
> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
Does this really "fix" something or is it just a useful cleanup? To me it
looks the latter.
--
i.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> #include <linux/sunserialcore.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-03 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 12:37 [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h> Geert Uytterhoeven
2022-05-02 12:37 ` [PATCH 2/2] serial: 8250: pxa: " Geert Uytterhoeven
2022-05-03 9:56 ` [PATCH 1/2] serial: 8250: core: " Andy Shevchenko
2022-05-03 12:24 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).