Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support

Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support

[Jernej Škrabec]

Hi!

Dne torek, 14. september 2021 ob 21:37:32 CEST je Dang Huynh napisal(a):
> This patch enables HDMI display on PINE64 PineTab.
> 
> The PineTab has a HDMI Type C (mini) port.
> 
> Signed-off-by: Dang Huynh <danct12@disroot.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/
arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> index 6a4af14718f5..adb0b28b06d8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> @@ -35,6 +35,17 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "c";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +
>  	i2c-csi {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&pio 4 13 GPIO_ACTIVE_HIGH>; /* PE13 */
> @@ -410,6 +421,21 @@ &reg_rtc_ldo {
>  	regulator-name = "vcc-rtc";
>  };
>  
> +&simplefb_hdmi {
> +	vcc-hdmi-supply = <&reg_dldo1>;

You have to set status to okay here.

With that fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> +};
> +
> +&hdmi {
> +	hvcc-supply = <&reg_dldo1>;
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
>  &sound {
>  	status = "okay";
>  	simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
> -- 
> 2.33.0
> 
> 

Re: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support

[Jernej Škrabec]

Dne sreda, 15. september 2021 ob 07:47:31 CEST je Dang Huynh napisal(a):
> On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej Škrabec wrote:
> > > +&simplefb_hdmi {
> > > +	vcc-hdmi-supply = <&reg_dldo1>;
> > 
> > You have to set status to okay here.

Sorry, this is actually the job of bootloader, so it's all good.

> > 
> > With that fixed, you can add:

No fixing needed for R-b tag.

> > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > 
> > Best regards,
> > Jernej
> > 
> 
> Is it really needed? The DE2 HDMI driver can be loaded and make this pretty 
> much obsolete.

DE2 and HDMI driver could read current settings from that node and implement 
flicker free transition. However, that's not supported yet. Another use case is 
to optimize kernel size to minimum for storing it in SPI flash by removing DRM 
driver if simplefb is good enough.

Anyway, patch looks good. Thanks!

Best regards,
Jernej

Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

On Wed, Sep 15, 2021 at 02:37:32AM +0700, Dang Huynh wrote:
> This patch enables HDMI display on PINE64 PineTab.
> 
> The PineTab has a HDMI Type C (mini) port.
> 
> Signed-off-by: Dang Huynh <danct12@disroot.org>

Applied, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]