* [PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED
@ 2022-07-11 8:42 Geert Uytterhoeven
2022-07-11 10:40 ` Jeremy Kerr
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-07-11 8:42 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Jeremy Kerr
Cc: linux-serial, linux-kernel, Geert Uytterhoeven
The Aspeed Virtual UART is only present on Aspeed BMC platforms. Hence
add a dependency on ARCH_ASPEED, to prevent asking the user about this
driver when configuring a kernel without Aspeed BMC support.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/8250/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index c621c21db7863278..6c1d2e70e497a19a 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -254,6 +254,7 @@ config SERIAL_8250_ASPEED_VUART
depends on SERIAL_8250
depends on OF
depends on REGMAP && MFD_SYSCON
+ depends on ARCH_ASPEED || COMPILE_TEST
help
If you want to use the virtual UART (VUART) device on Aspeed
BMC platforms, enable this option. This enables the 16550A-
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED
2022-07-11 8:42 [PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED Geert Uytterhoeven
@ 2022-07-11 10:40 ` Jeremy Kerr
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Kerr @ 2022-07-11 10:40 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby
Cc: linux-serial, linux-kernel
Hi Geert,
> The Aspeed Virtual UART is only present on Aspeed BMC platforms.
> Hence add a dependency on ARCH_ASPEED, to prevent asking the user
> about this driver when configuring a kernel without Aspeed BMC
> support.
All fine by me. It'd be super weird if this hardware appeared on a
non-ASPEED platform.
Reviewed-by: Jeremy Kerr <jk@ozlabs.org>
Cheers,
Jeremy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-11 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-11 8:42 [PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED Geert Uytterhoeven
2022-07-11 10:40 ` Jeremy Kerr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).