linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>,
	"qla2xxx-upstream@qlogic.com" <qla2xxx-upstream@qlogic.com>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O
Date: Tue, 8 Nov 2016 17:47:44 +0000	[thread overview]
Message-ID: <25A8D59D-ED2B-4E97-80DD-36F347862DEC@cavium.com> (raw)
In-Reply-To: <1478548411-17932-1-git-send-email-mauricfo@linux.vnet.ibm.com>



On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" <mauricfo@linux.vnet.ibm.com> wrote:

>This patchset addresses a couple of errors that might happen during
>PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent
>the successful removal and re-addition of the adapter to the system,
>and cause an oops and/or invalid DMA access (triggers an EEH event).
>
>It allowed several cycles of PCI device add/remove with ongoing I/O,
>to complete successfully without triggering oopses or EEH events.
>
>Verified on v4.9-rc3.
>
>Test-case:
>---
>    # lspci
>    <...>
>    001d:70:00.0 Fibre Channel: QLogic Corp. ISP2532-based ...
>    001d:70:00.1 Fibre Channel: QLogic Corp. ISP2532-based ...
>    <...>
>
>    # for sd in $(find /sys/bus/pci/devices/001d:70:00.*/ \
>                       -name 'sd*' -printf "%f\n"); do \
>        dd if=/dev/$sd of=/dev/null iflag=nocache & done
>
>    # echo 1 | tee /sys/bus/pci/devices/001d:70:00.*/remove
>    (this either works or not)
>
>    # echo 1 > /sys/bus/pci/rescan
>
>Before:
>---
>    <...>
>    EEH: Frozen PHB#1d-PE#700000 detected
>    qla2xxx [001d:70:00.1]-8042:2: PCI/Register disconnect, exiting.
>    <...>
>    EEH: Detected PCI bus error on PHB#29-PE#700000
>    <...>
>    (and/or)
>    Unable to handle kernel paging request for data at address 0x00000138
>    <...>
>    NIP [d000000004700a40] qla2xxx_queuecommand+0x80/0x3f0 [qla2xxx]
>    LR [d000000004700a10] qla2xxx_queuecommand+0x50/0x3f0 [qla2xxx]
>
>    (command does not return; adapter cannot be re-added)
>
>After:
>---
>    <...>
>    qla2xxx [001d:70:00.0]-801c:1: Abort command issued nexus=1:0:0 --  1 2003.
>    <...>
>    qla2xxx [001d:70:00.1]-801c:2: Abort command issued nexus=2:3:0 --  1 2003.
>    <...>
>
>    (command does return; adapter can be re-added correctly)
>
>
>Mauricio Faria de Oliveira (2):
>  qla2xxx: do not queue commands when unloading
>  qla2xxx: fix invalid DMA access after command aborts in PCI device
>    remove
>
> drivers/scsi/qla2xxx/qla_os.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>-- 
>1.8.3.1
>
Thanks for the patches. Series Looks Good. 

Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>

>

  parent reply	other threads:[~2016-11-08 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 19:53 Mauricio Faria de Oliveira
2016-11-07 19:53 ` [PATCH 1/2] qla2xxx: do not queue commands when unloading Mauricio Faria de Oliveira
2016-11-07 19:53 ` [PATCH 2/2] qla2xxx: fix invalid DMA access after command aborts in PCI device remove Mauricio Faria de Oliveira
2016-11-08 17:47 ` Madhani, Himanshu [this message]
2016-11-09  0:14 ` [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25A8D59D-ED2B-4E97-80DD-36F347862DEC@cavium.com \
    --to=himanshu.madhani@cavium.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mauricfo@linux.vnet.ibm.com \
    --cc=qla2xxx-upstream@qlogic.com \
    --subject='Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).