* [PATCH] drm: ttm: virtio-gpu: dma-buf: Constify ttm_place structures.
@ 2017-07-02 7:41 Arvind Yadav
2017-07-03 9:48 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-02 7:41 UTC (permalink / raw)
To: airlied, kraxel; +Cc: dri-devel, virtualization, linux-kernel
ttm_place are not supposed to change at runtime. All functions
working with ttm_place provided by <drm/ttm/ttm_placement.h> work
with const ttm_place. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2315 184 0 2499 9c3 drivers/gpu/drm/virtio/virtgpu_ttm.o
File size After adding 'const':
text data bss dec hex filename
2347 152 0 2499 9c3 drivers/gpu/drm/virtio/virtgpu_ttm.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
index 4e8e27d..012d5bc 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
@@ -234,7 +234,7 @@ static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
static void virtio_gpu_evict_flags(struct ttm_buffer_object *bo,
struct ttm_placement *placement)
{
- static struct ttm_place placements = {
+ static const struct ttm_place placements = {
.fpfn = 0,
.lpfn = 0,
.flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: ttm: virtio-gpu: dma-buf: Constify ttm_place structures.
2017-07-02 7:41 [PATCH] drm: ttm: virtio-gpu: dma-buf: Constify ttm_place structures Arvind Yadav
@ 2017-07-03 9:48 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2017-07-03 9:48 UTC (permalink / raw)
To: Arvind Yadav, airlied; +Cc: dri-devel, virtualization, linux-kernel
On Sun, 2017-07-02 at 13:11 +0530, Arvind Yadav wrote:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex
> filename
> 2315 184 0 2499 9c3
> drivers/gpu/drm/virtio/virtgpu_ttm.o
>
> File size After adding 'const':
> text data bss dec hex
> filename
> 2347 152 0 2499 9c3
> drivers/gpu/drm/virtio/virtgpu_ttm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
pushed to drm-misc-next (qxl patch too).
cheers,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-03 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 7:41 [PATCH] drm: ttm: virtio-gpu: dma-buf: Constify ttm_place structures Arvind Yadav
2017-07-03 9:48 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).