* [PATCH] x86/resctrl: add printf attribute to log function
@ 2020-12-21 16:00 trix
2021-01-07 21:51 ` Reinette Chatre
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: trix @ 2020-12-21 16:00 UTC (permalink / raw)
To: fenghua.yu, reinette.chatre, tglx, mingo, bp, hpa
Cc: x86, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Attributing the function allows the compiler to more thoroughly
check the use of the function with -Wformat and similar flags.
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47844cb..c4d320d02fd5 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
void rdt_last_cmd_clear(void);
void rdt_last_cmd_puts(const char *s);
+__printf(1, 2)
void rdt_last_cmd_printf(const char *fmt, ...);
void rdt_ctrl_update(void *arg);
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/resctrl: add printf attribute to log function
2020-12-21 16:00 [PATCH] x86/resctrl: add printf attribute to log function trix
@ 2021-01-07 21:51 ` Reinette Chatre
2021-01-08 8:01 ` [tip: x86/cache] x86/resctrl: Add " tip-bot2 for Tom Rix
2021-01-11 10:50 ` tip-bot2 for Tom Rix
2 siblings, 0 replies; 4+ messages in thread
From: Reinette Chatre @ 2021-01-07 21:51 UTC (permalink / raw)
To: trix, fenghua.yu, tglx, mingo, bp, hpa; +Cc: x86, linux-kernel
Hi Tom,
On 12/21/2020 8:00 AM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> arch/x86/kernel/cpu/resctrl/internal.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..c4d320d02fd5 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
>
> void rdt_last_cmd_clear(void);
> void rdt_last_cmd_puts(const char *s);
> +__printf(1, 2)
> void rdt_last_cmd_printf(const char *fmt, ...);
>
> void rdt_ctrl_update(void *arg);
>
This is a valuable addition, thank you.
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: x86/cache] x86/resctrl: Add printf attribute to log function
2020-12-21 16:00 [PATCH] x86/resctrl: add printf attribute to log function trix
2021-01-07 21:51 ` Reinette Chatre
@ 2021-01-08 8:01 ` tip-bot2 for Tom Rix
2021-01-11 10:50 ` tip-bot2 for Tom Rix
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Tom Rix @ 2021-01-08 8:01 UTC (permalink / raw)
To: linux-tip-commits
Cc: Tom Rix, Borislav Petkov, Reinette Chatre, x86, linux-kernel
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: 91031e096e1fa0216027bfb7fdca931225aebbf0
Gitweb: https://git.kernel.org/tip/91031e096e1fa0216027bfb7fdca931225aebbf0
Author: Tom Rix <trix@redhat.com>
AuthorDate: Mon, 21 Dec 2020 08:00:09 -08:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Fri, 08 Jan 2021 08:55:02 +01:00
x86/resctrl: Add printf attribute to log function
Mark the function with the __printf attribute to allow the compiler to
more thoroughly typecheck its arguments against a format string with
-Wformat and similar flags.
[ bp: Massage commit message. ]
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lkml.kernel.org/r/20201221160009.3752017-1-trix@redhat.com
---
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47..c4d320d 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
void rdt_last_cmd_clear(void);
void rdt_last_cmd_puts(const char *s);
+__printf(1, 2)
void rdt_last_cmd_printf(const char *fmt, ...);
void rdt_ctrl_update(void *arg);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip: x86/cache] x86/resctrl: Add printf attribute to log function
2020-12-21 16:00 [PATCH] x86/resctrl: add printf attribute to log function trix
2021-01-07 21:51 ` Reinette Chatre
2021-01-08 8:01 ` [tip: x86/cache] x86/resctrl: Add " tip-bot2 for Tom Rix
@ 2021-01-11 10:50 ` tip-bot2 for Tom Rix
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Tom Rix @ 2021-01-11 10:50 UTC (permalink / raw)
To: linux-tip-commits
Cc: Tom Rix, Borislav Petkov, Reinette Chatre, x86, linux-kernel
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: 3ff4ec0e281d0b234917e6e3033dd3067a5ea945
Gitweb: https://git.kernel.org/tip/3ff4ec0e281d0b234917e6e3033dd3067a5ea945
Author: Tom Rix <trix@redhat.com>
AuthorDate: Mon, 21 Dec 2020 08:00:09 -08:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 11 Jan 2021 11:20:36 +01:00
x86/resctrl: Add printf attribute to log function
Mark the function with the __printf attribute to allow the compiler to
more thoroughly typecheck its arguments against a format string with
-Wformat and similar flags.
[ bp: Massage commit message. ]
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lkml.kernel.org/r/20201221160009.3752017-1-trix@redhat.com
---
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47..c4d320d 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -572,6 +572,7 @@ union cpuid_0x10_x_edx {
void rdt_last_cmd_clear(void);
void rdt_last_cmd_puts(const char *s);
+__printf(1, 2)
void rdt_last_cmd_printf(const char *fmt, ...);
void rdt_ctrl_update(void *arg);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-11 10:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 16:00 [PATCH] x86/resctrl: add printf attribute to log function trix
2021-01-07 21:51 ` Reinette Chatre
2021-01-08 8:01 ` [tip: x86/cache] x86/resctrl: Add " tip-bot2 for Tom Rix
2021-01-11 10:50 ` tip-bot2 for Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).