From: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM
Date: Wed, 22 Mar 2023 19:04:05 +0530 [thread overview]
Message-ID: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> (raw)
In-Reply-To: <c0c6c79b-ac77-cdbf-5b08-38b89e4fe481@linaro.org>
On 3/21/2023 11:01 PM, Krzysztof Kozlowski wrote:
> On 21/03/2023 14:51, Souradeep Chowdhury wrote:
>> All Qualcomm bootloaders log useful timestamp information related
>> to bootloader stats in the IMEM region. Add the child node within
>> IMEM for the boot stat region containing register address and
>> compatible string.
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
>> ---
>> .../devicetree/bindings/sram/qcom,imem.yaml | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> index 665c06e..c8c3890 100644
>> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
>> @@ -48,6 +48,26 @@ patternProperties:
>> $ref: /schemas/remoteproc/qcom,pil-info.yaml#
>> description: Peripheral image loader relocation region
>>
>> + "^boot-stat@[0-9a-f]+$":
>> + type: object
>> + description:
>> + node for boot stat.
>
> This basically copies the name of node, so not really helpful. Describe
> what's this.
Ack
>
>> +
>
> additionalProperties: false
>
>> + properties:
>> + compatible:
>> + items:
>
> Drop items.
>
>> + - const: qcom,imem-boot_stats
>
> No underscores in compatibles. Why this is not SoC specific compatible?
Ack. The boot_stats module is not specific to a device. It is written to
read some values from this imem region which is present for almost all
QCOM SoCs. So SoC specific compatible is not given in this case.
>
>> +
>> + reg:
>> + maxItems: 1
>> + description:
>> + The base address of the register region in case of
>> + imem boot stats.
>
> Drop description, it's obvious.
Ack
>> +
>> + required:
>> + - compatible
>> + - reg
>> +
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-22 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:51 [PATCH V1 0/4] soc: qcom: boot_stats: Add driver support for boot_stats Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Souradeep Chowdhury
2023-03-21 17:31 ` Krzysztof Kozlowski
2023-03-22 13:34 ` Souradeep Chowdhury [this message]
2023-03-22 16:27 ` Krzysztof Kozlowski
2023-03-23 13:46 ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Souradeep Chowdhury
2023-03-21 17:33 ` Krzysztof Kozlowski
2023-03-22 13:46 ` Souradeep Chowdhury
2023-03-22 16:29 ` Krzysztof Kozlowski
2023-03-23 13:49 ` Souradeep Chowdhury
2023-03-21 17:39 ` Krzysztof Kozlowski
2023-03-22 14:02 ` Souradeep Chowdhury
2023-03-22 16:31 ` Krzysztof Kozlowski
2023-03-23 13:51 ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 3/4] soc: qcom: boot_stat: Add Driver Support for Boot Stats Souradeep Chowdhury
2023-03-21 17:37 ` Krzysztof Kozlowski
2023-03-22 13:54 ` Souradeep Chowdhury
2023-03-22 14:53 ` Krzysztof Kozlowski
2023-03-23 13:45 ` Souradeep Chowdhury
2023-03-24 8:56 ` Krzysztof Kozlowski
2023-03-21 13:51 ` [PATCH V1 4/4] MAINTAINERS: Add the entry for boot_stats driver support Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com \
--to=quic_schowdhu@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).