From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema
Date: Tue, 21 Mar 2023 18:33:18 +0100 [thread overview]
Message-ID: <fc46c48d-2de0-ba3a-08b0-a09526bd9e26@linaro.org> (raw)
In-Reply-To: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com>
On 21/03/2023 14:51, Souradeep Chowdhury wrote:
> Add the device tree bindings for the module power manager sleep
> counter.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> .../bindings/soc/qcom/qcom,mpm-sleep-counter.yaml | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
> new file mode 100644
> index 0000000..f9f46b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,mpm-sleep-counter.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,mpm-sleep-counter.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MPM Sleep Counter
> +
> +maintainers:
> + - Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> +
> +description: |
> + MPM(Module Power Manager) has a sleep counter which is used to track
Missing space:
MPM (Module
> + various stages of the boot process in Qualcomm.
in Qualcomm SoC. Because you do not track it in the company...
> +
> +properties:
> + compatible:
> + items:
Drop items.
> + - const: qcom,mpm2-sleep-counter
SoC specific compatible.
> +
> + reg:
> + items:
> + - description: MPM Sleep Counter Base
just maxItems: 1
> +
> + clock-frequency:
> + description: Frequency for the sleep counter
Since this does not have clocks, what frequency you are setting here?
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mpm2-sleep-counter@c221000{
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "qcom,mpm2-sleep-counter";
> + reg = <0xc221000 0x1000>;
> + clock-frequency = <32768>;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-21 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:51 [PATCH V1 0/4] soc: qcom: boot_stats: Add driver support for boot_stats Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Souradeep Chowdhury
2023-03-21 17:31 ` Krzysztof Kozlowski
2023-03-22 13:34 ` Souradeep Chowdhury
2023-03-22 16:27 ` Krzysztof Kozlowski
2023-03-23 13:46 ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Souradeep Chowdhury
2023-03-21 17:33 ` Krzysztof Kozlowski [this message]
2023-03-22 13:46 ` Souradeep Chowdhury
2023-03-22 16:29 ` Krzysztof Kozlowski
2023-03-23 13:49 ` Souradeep Chowdhury
2023-03-21 17:39 ` Krzysztof Kozlowski
2023-03-22 14:02 ` Souradeep Chowdhury
2023-03-22 16:31 ` Krzysztof Kozlowski
2023-03-23 13:51 ` Souradeep Chowdhury
2023-03-21 13:51 ` [PATCH V1 3/4] soc: qcom: boot_stat: Add Driver Support for Boot Stats Souradeep Chowdhury
2023-03-21 17:37 ` Krzysztof Kozlowski
2023-03-22 13:54 ` Souradeep Chowdhury
2023-03-22 14:53 ` Krzysztof Kozlowski
2023-03-23 13:45 ` Souradeep Chowdhury
2023-03-24 8:56 ` Krzysztof Kozlowski
2023-03-21 13:51 ` [PATCH V1 4/4] MAINTAINERS: Add the entry for boot_stats driver support Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc46c48d-2de0-ba3a-08b0-a09526bd9e26@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).