From: Hans de Goede <hdegoede@redhat.com>
To: "Luck, Tony" <tony.luck@intel.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "Joseph, Jithu" <jithu.joseph@intel.com>,
"markgross@kernel.org" <markgross@kernel.org>,
"Raj, Ashok" <ashok.raj@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: Re: [PATCH v2] platform/x86/intel/ifs: Allow non-default names for IFS image
Date: Thu, 28 Jul 2022 20:48:00 +0200 [thread overview]
Message-ID: <26102aca-a730-ddf8-d024-2e7367696757@redhat.com> (raw)
In-Reply-To: <SJ1PR11MB6083263E8EEBF106B6B61B24FC969@SJ1PR11MB6083.namprd11.prod.outlook.com>
Hi Tony,
On 7/28/22 17:12, Luck, Tony wrote:
>>>> Speculating myself as far as I understand IFS is not for factory
>>>> tests but for testing in the fields since big cloud vendors have
>>>> found that sometimes there are hard to catch CPU defects which
>>>> they only find out by running statistics which show that certain
>>>> tasks only crash when run on machine a, socket b, core c.
>>>
>>> Who knows, Intel doesn't say so we can't really guess :(
>>
>> Right, for version 3 the commit message and ABI documentation changes
>> really need to clarify why multiple test-pattern files may be needed
>> mucy better. If possible please also include 1 or 2 _clear_ examples
>> of cases where more then 1 test-pattern file may be used.
>
> Sorry for the radio silence. We took Greg's suggestion to go back and
> thinks this out completely to heart. As he said, there is no rush to get
> this in. We need to do it right.
That (taking your time to get this right) is good to hear, thanks.
> Your summary above on how this works is completely correct.
>
> The reason for adding more files is to cover more transistors in the
> core. The base file that we started with gets mumble-mumble percent
> of the transistors checked. Adding a few more files will increase that
> quite significantly.
>
> So testing a system may look like:
>
> for each scan file
> do
> load the scan file
> for each core
> do
> test the core with this set of tests
> done
> done
>
> Our internal discussions on naming are following the same direction that
> you suggested, but likely even more restrictive. The "suffix" may just be
> a two-digit hex number (allowing for up to 256 files ... though for Sapphire
> Rapids we are looking at just 6).
>
> So our current direction is to name six "parts" something like this:
>
> 06-8f-06-00.scan
> 06-8f-06-01.scan
> 06-8f-06-02.scan
> 06-8f-06-03.scan
> 06-8f-06-04.scan
> 06-8f-06-05.scan
>
> but we are still checking to make sure this will work for future CPUs. Once
> we have something solid we will come back to the mailing list.
Thanks, this sounds good to me.
> As also suggested in earlier thread we will change the name of the "reload"
> file (since skipping to a new file isn't a "reload"). The "load a scan file" will
> write the "part" number to this new file.
Regards,
Hans
next prev parent reply other threads:[~2022-07-28 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 16:00 [PATCH v2] platform/x86/intel/ifs: Allow non-default names for IFS image Jithu Joseph
2022-07-10 16:12 ` Hans de Goede
2022-07-10 16:43 ` Joseph, Jithu
2022-07-10 18:12 ` Luck, Tony
2022-07-10 16:59 ` Greg KH
2022-07-28 11:57 ` Hans de Goede
2022-07-28 12:07 ` Greg KH
2022-07-28 12:52 ` Hans de Goede
2022-07-28 12:59 ` Greg KH
2022-07-28 13:17 ` Hans de Goede
2022-07-28 15:12 ` Luck, Tony
2022-07-28 18:48 ` Hans de Goede [this message]
2022-07-10 17:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26102aca-a730-ddf8-d024-2e7367696757@redhat.com \
--to=hdegoede@redhat.com \
--cc=ashok.raj@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).