linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jithu Joseph <jithu.joseph@intel.com>
Cc: hdegoede@redhat.com, markgross@kernel.org, ashok.raj@intel.com,
	tony.luck@intel.com, ravi.v.shankar@intel.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v2] platform/x86/intel/ifs: Allow non-default names for IFS image
Date: Sun, 10 Jul 2022 19:00:41 +0200	[thread overview]
Message-ID: <YssFueUGqzq2WLHa@kroah.com> (raw)
In-Reply-To: <20220710160011.995800-1-jithu.joseph@intel.com>

On Sun, Jul 10, 2022 at 09:00:11AM -0700, Jithu Joseph wrote:
> Existing implementation limits IFS images to be loaded only from
> a default file-name /lib/firmware/intel/ifs/ff-mm-ss.scan.
> 
> But there are situations where there may be multiple scan files
> that can be run on a particular system stored in /lib/firmware/intel/ifs
> 
> E.g.
> 1. Because test contents are larger than the memory reserved for IFS by BIOS
> 2. To provide increased test coverage
> 3. Custom test files to debug certain specific issues in the field
> 
> Renaming each of these to ff-mm-ss.scan and then loading might be
> possible in some environments. But on systems where /lib is read-only
> this is not a practical solution.
> 
> Modify the semantics of the driver file
> /sys/devices/virtual/misc/intel_ifs_0/reload such that,
> it interprets the input as the filename to be loaded.
> 
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> ---

Also note that this does not follow the required Intel rules for
submitting kernel patches.  Why the rush and circumventing of the normal
process that we have in place for good reasons?

greg k-h

      parent reply	other threads:[~2022-07-10 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 16:00 [PATCH v2] platform/x86/intel/ifs: Allow non-default names for IFS image Jithu Joseph
2022-07-10 16:12 ` Hans de Goede
2022-07-10 16:43   ` Joseph, Jithu
2022-07-10 18:12   ` Luck, Tony
2022-07-10 16:59 ` Greg KH
2022-07-28 11:57   ` Hans de Goede
2022-07-28 12:07     ` Greg KH
2022-07-28 12:52       ` Hans de Goede
2022-07-28 12:59         ` Greg KH
2022-07-28 13:17           ` Hans de Goede
2022-07-28 15:12             ` Luck, Tony
2022-07-28 18:48               ` Hans de Goede
2022-07-10 17:00 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YssFueUGqzq2WLHa@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ashok.raj@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=jithu.joseph@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).