From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] phy-sun4i-usb: select 'USB_COMMON'
Date: Fri, 09 Sep 2016 11:25:45 +0200 [thread overview]
Message-ID: <2629582.eurAq3q4Wx@wuerfel> (raw)
In-Reply-To: <57D1699C.4080406@ti.com>
In commit "usb: phy: add USB_SUPPORT dependency", I tried to
fix the dependency for this driver, but unfortunately I missed
that we need both USB_COMMON and USB_SUPPORT here, and we
can still get the same link error in the much rarer case
that USB_COMMON is a loadable module and the phy driver is
build-in:
drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to `of_usb_get_dr_mode_by_phy'
This adds the select, hopefully fixing it properly this time.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I see the original patch hasn't made it into linux-next
yet, so ideally just fold this patch into the first one.
Sorry for not getting it right the first time around.
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 985dff8558e5..c717f306d131 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -262,6 +262,7 @@ config PHY_SUN4I_USB
depends on POWER_SUPPLY
depends on USB_SUPPORT
select GENERIC_PHY
+ select USB_COMMON
help
Enable this to support the transceiver that is part of Allwinner
sunxi SoCs.
next prev parent reply other threads:[~2016-09-09 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 12:54 [PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann
2016-09-07 9:31 ` Hans de Goede
2016-09-08 13:37 ` Kishon Vijay Abraham I
2016-09-09 9:25 ` Arnd Bergmann [this message]
2016-09-09 9:42 ` [PATCH] phy-sun4i-usb: select 'USB_COMMON' Hans de Goede
2016-09-09 10:04 ` Arnd Bergmann
2016-09-14 13:51 ` [PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2629582.eurAq3q4Wx@wuerfel \
--to=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).