From: Kishon Vijay Abraham I <kishon@ti.com>
To: Hans de Goede <hdegoede@redhat.com>, Arnd Bergmann <arnd@arndb.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: phy: add USB_SUPPORT dependency
Date: Thu, 8 Sep 2016 19:07:32 +0530 [thread overview]
Message-ID: <57D1699C.4080406@ti.com> (raw)
In-Reply-To: <20915b65-8be3-cee4-cac1-eab512ab74f5@redhat.com>
On Wednesday 07 September 2016 03:01 PM, Hans de Goede wrote:
> Hi,
>
> On 06-09-16 14:54, Arnd Bergmann wrote:
>> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
>> USB core layer, and it fails to build when that is not provided:
>>
>> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
>> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to
>> `of_usb_get_dr_mode_by_phy'
>>
>> We already have a couple of other PHY drivers with a dependency
>> on USB_SUPPORT, so that seems to be the easiest fix here.
>>
>> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
>> to also check for CONFIG_USB_SUPPORT.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
>
> Good catch, patch LGTM:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
merged, thanks.
-Kishon
>
> Regards,
>
> Hans
>
>
>
>> ---
>> drivers/phy/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index c42ddf3c8ed8..985dff8558e5 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -260,6 +260,7 @@ config PHY_SUN4I_USB
>> depends on RESET_CONTROLLER
>> depends on EXTCON
>> depends on POWER_SUPPLY
>> + depends on USB_SUPPORT
>> select GENERIC_PHY
>> help
>> Enable this to support the transceiver that is part of Allwinner
>>
next prev parent reply other threads:[~2016-09-08 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 12:54 [PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann
2016-09-07 9:31 ` Hans de Goede
2016-09-08 13:37 ` Kishon Vijay Abraham I [this message]
2016-09-09 9:25 ` [PATCH] phy-sun4i-usb: select 'USB_COMMON' Arnd Bergmann
2016-09-09 9:42 ` Hans de Goede
2016-09-09 10:04 ` Arnd Bergmann
2016-09-14 13:51 ` [PATCH] usb: phy: add USB_SUPPORT dependency Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D1699C.4080406@ti.com \
--to=kishon@ti.com \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).