From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux@armlinux.org.uk, xc-racer2@live.ca,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: dts: s5pv210: aries: Support for more devices present on Aries
Date: Tue, 08 Jan 2019 17:53:09 +0100 [thread overview]
Message-ID: <2674227.8dsLnzbNuO@acerlaptop> (raw)
In-Reply-To: <CAJKOXPf3Z9=mjq_UWyD1oVEapvnNR71cDfyJP1Y_VLkXkFcyew@mail.gmail.com>
Dnia poniedziałek, 31 grudnia 2018 14:35:55 CET Krzysztof Kozlowski pisze:
> On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
> <pawel.mikolaj.chmiel@gmail.com> wrote:
> >
> > From: Jonathan Bakker <xc-racer2@live.ca>
> >
> > This commit enables following devices present on Aries based phones:
> > - pwm-vibrator attached to PWM 1
> > - poweroff support
> > - Atmel maXTouch touchscreen. It's connected to i2c2
> > - Broadcom BCM4329 bluetooth over uart0
> >
> > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> > ---
> > arch/arm/boot/dts/s5pv210-aries.dtsi | 68 ++++++++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> > index 35ba009a1a33..b7246f879648 100644
> > --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> > @@ -41,6 +41,13 @@
> > };
> > };
> >
> > + vibrator_pwr: regulator-fixed-0 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vibrator-en";
> > + enable-active-high;
> > + gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> > + };
> > +
> > wifi_pwrseq: wifi-pwrseq {
> > compatible = "mmc-pwrseq-simple";
> > reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> > @@ -314,6 +321,22 @@
> > reg = <0x36>;
> > };
> > };
> > +
> > + vibrator: pwm-vibrator {
> > + compatible = "pwm-vibrator";
> > + pwms = <&pwm 1 44642 0>;
> > + pwm-names = "enable";
> > + vcc-supply = <&vibrator_pwr>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm1_out>;
> > + };
> > +
> > + poweroff: syscon-poweroff {
> > + compatible = "syscon-poweroff";
> > + regmap = <&pmu_syscon>;
> > + offset = <0x681c>; /* PS_HOLD_CONTROL */
> > + value = <0x5200>;
> > + };
> > };
> >
> > &fimd {
> > @@ -347,6 +370,23 @@
> > status = "okay";
> > };
> >
> > +&i2c2 {
> > + samsung,i2c-sda-delay = <100>;
> > + samsung,i2c-max-bus-freq = <400000>;
> > + samsung,i2c-slave-addr = <0x10>;
> > + status = "okay";
> > +
> > + touchscreen@4a {
> > + compatible = "atmel,maxtouch";
> > + reg = <0x4a>;
> > + interrupt-parent = <&gpj0>;
> > + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ts_irq>;
> > + reset-gpios = <&gpj1 3 GPIO_ACTIVE_HIGH>;
> > + };
> > +};
> > +
> > &mfc {
> > memory-region = <&mfc_left>, <&mfc_right>;
> > };
> > @@ -372,6 +412,13 @@
> > samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > };
> >
> > + bt_host_wake: bt-host-wake {
> > + samsung,pins = "gph2-5";
> > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > + samsung,pin-pud = <S3C64XX_PIN_PULL_DOWN>;
> > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > + };
> > +
> > tf_detect: tf-detect {
> > samsung,pins = "gph3-4";
> > samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > @@ -384,6 +431,17 @@
> > samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> > samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> > };
> > +
> > + ts_irq: ts-irq {
> > + samsung,pins = "gpj0-5";
> > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> > + samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
>
> It seems there is a difference here between Aries and Fascinate. At
> least in vendor kernel. One disables pull and second pulls down.
> Anyway neither of them pulls it up.
Fixed with all other issues in v2.
Thanks
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2019-01-08 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 16:18 [PATCH 0/6] ARM: dts: s5pv210: aries: Enable more drivers present on Samsung Aries based devices Paweł Chmiel
2018-12-28 16:18 ` [PATCH 1/6] ARM: dts: s5pv210: Use correct fimd variant Paweł Chmiel
2018-12-31 11:37 ` Krzysztof Kozlowski
2019-01-07 20:28 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 2/6] ARM: dts: s5pv210: galaxys: Remove hardcoded bootargs Paweł Chmiel
2019-01-07 19:20 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 3/6] ARM: dts: s5pv210: fascinate4g: " Paweł Chmiel
2019-01-07 19:20 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 4/6] ARM: dts: s5pv210: aries: Add reserved memory for mfc Paweł Chmiel
2018-12-31 11:44 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 5/6] ARM: dts: s5pv210: aries: Support for more devices present on Aries Paweł Chmiel
2018-12-31 13:35 ` Krzysztof Kozlowski
2019-01-08 16:53 ` Paweł Chmiel [this message]
2018-12-28 16:18 ` [PATCH 6/6] ARM: defconfig: s5pv210: Enable more drivers present on Samsung Aries Paweł Chmiel
2018-12-31 13:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2674227.8dsLnzbNuO@acerlaptop \
--to=pawel.mikolaj.chmiel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).