From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux@armlinux.org.uk, xc-racer2@live.ca,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] ARM: dts: s5pv210: Use correct fimd variant
Date: Mon, 31 Dec 2018 12:37:28 +0100 [thread overview]
Message-ID: <CAJKOXPf+Ut1ghXJnEqrUiz=r_ts-Bz3cum1LvUMOjEqWp8q+Vw@mail.gmail.com> (raw)
In-Reply-To: <20181228161819.18931-2-pawel.mikolaj.chmiel@gmail.com>
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:
>
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.
Please fix
your editor
to wrap lines
matching Linux
style because
it is difficult
to read.
You have unusual configuration because most of the editors wrap git
commit as expected.
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633
Best regards,
Krzysztof
>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 75f454a210d6..3d6e5ad1ea35 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -511,7 +511,7 @@
> };
>
> fimd: fimd@f8000000 {
> - compatible = "samsung,exynos4210-fimd";
> + compatible = "samsung,s5pv210-fimd";
> interrupt-parent = <&vic2>;
> reg = <0xf8000000 0x20000>;
> interrupt-names = "fifo", "vsync", "lcd_sys";
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-12-31 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 16:18 [PATCH 0/6] ARM: dts: s5pv210: aries: Enable more drivers present on Samsung Aries based devices Paweł Chmiel
2018-12-28 16:18 ` [PATCH 1/6] ARM: dts: s5pv210: Use correct fimd variant Paweł Chmiel
2018-12-31 11:37 ` Krzysztof Kozlowski [this message]
2019-01-07 20:28 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 2/6] ARM: dts: s5pv210: galaxys: Remove hardcoded bootargs Paweł Chmiel
2019-01-07 19:20 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 3/6] ARM: dts: s5pv210: fascinate4g: " Paweł Chmiel
2019-01-07 19:20 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 4/6] ARM: dts: s5pv210: aries: Add reserved memory for mfc Paweł Chmiel
2018-12-31 11:44 ` Krzysztof Kozlowski
2018-12-28 16:18 ` [PATCH 5/6] ARM: dts: s5pv210: aries: Support for more devices present on Aries Paweł Chmiel
2018-12-31 13:35 ` Krzysztof Kozlowski
2019-01-08 16:53 ` Paweł Chmiel
2018-12-28 16:18 ` [PATCH 6/6] ARM: defconfig: s5pv210: Enable more drivers present on Samsung Aries Paweł Chmiel
2018-12-31 13:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPf+Ut1ghXJnEqrUiz=r_ts-Bz3cum1LvUMOjEqWp8q+Vw@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).