* Re:[RFC/PATCH PATCH 6/6] lockdep: Consider the rw_state of lock while validating the chain.
@ 2009-06-01 5:05 Yong Zhang
0 siblings, 0 replies; only message in thread
From: Yong Zhang @ 2009-06-01 5:05 UTC (permalink / raw)
To: ego; +Cc: linux-kernel
<...>
>@@ -1767,9 +1773,15 @@ static int validate_chain(struct task_struct *curr, struct lockdep_map *lock,
>
> if (!ret)
> return 0;
>+
>+ if (ret != 2 && is_rec_read(hlock->rw_state))
>+ hlock->rw_state |= STATE_FIRST_RECURSIVE_READ;
>+
>+
> /*
> * Add dependency only if this lock is not the head
>- * of the chain, and if it's not a secondary read-lock:
>+ * of the chain, and if it's not the first instance of
>+ * the recursive read-lock:
This change maybe don't show what you want to say.
Maybe it should be "or if it's the first instance of the recursive read-lock."
> */
> if (!chain_head && ret != 2)
> if (!check_prevs_add(curr, hlock))
<...>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-06-01 5:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-01 5:05 Re:[RFC/PATCH PATCH 6/6] lockdep: Consider the rw_state of lock while validating the chain Yong Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).