* [PATCH] regulator: bd9571mwv: Statize local symbols
@ 2017-05-28 6:02 Axel Lin
2017-05-28 12:20 ` Marek Vasut
2017-06-06 19:07 ` Applied "regulator: bd9571mwv: Statize local symbols" to the regulator tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2017-05-28 6:02 UTC (permalink / raw)
To: Mark Brown; +Cc: Marek Vasut, Liam Girdwood, linux-kernel, Axel Lin
These functions are only used by this driver, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/bd9571mwv-regulator.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
index 8ba206f..c67a83d 100644
--- a/drivers/regulator/bd9571mwv-regulator.c
+++ b/drivers/regulator/bd9571mwv-regulator.c
@@ -43,7 +43,7 @@ enum bd9571mwv_regulators { VD09, VD18, VD25, VD33, DVFS };
.linear_min_sel = _lmin, \
}
-int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
+static int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
{
unsigned int val;
int ret;
@@ -55,8 +55,8 @@ int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
return val & BD9571MWV_AVS_SET_MONI_MASK;
}
-int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
- unsigned int sel)
+static int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
+ unsigned int sel)
{
int ret;
@@ -68,7 +68,7 @@ int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
rdev->desc->vsel_mask, sel);
}
-int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
+static int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
{
unsigned int val;
int ret;
@@ -87,8 +87,8 @@ int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
return val;
}
-int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
- unsigned int sel)
+static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
+ unsigned int sel)
{
return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
rdev->desc->vsel_mask, sel);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: bd9571mwv: Statize local symbols
2017-05-28 6:02 [PATCH] regulator: bd9571mwv: Statize local symbols Axel Lin
@ 2017-05-28 12:20 ` Marek Vasut
2017-06-06 19:07 ` Applied "regulator: bd9571mwv: Statize local symbols" to the regulator tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2017-05-28 12:20 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: Marek Vasut, Liam Girdwood, linux-kernel
On 05/28/2017 08:02 AM, Axel Lin wrote:
> These functions are only used by this driver, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Obviously correct,
Acked-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> drivers/regulator/bd9571mwv-regulator.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
> index 8ba206f..c67a83d 100644
> --- a/drivers/regulator/bd9571mwv-regulator.c
> +++ b/drivers/regulator/bd9571mwv-regulator.c
> @@ -43,7 +43,7 @@ enum bd9571mwv_regulators { VD09, VD18, VD25, VD33, DVFS };
> .linear_min_sel = _lmin, \
> }
>
> -int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
> {
> unsigned int val;
> int ret;
> @@ -55,8 +55,8 @@ int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
> return val & BD9571MWV_AVS_SET_MONI_MASK;
> }
>
> -int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> - unsigned int sel)
> +static int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> + unsigned int sel)
> {
> int ret;
>
> @@ -68,7 +68,7 @@ int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> rdev->desc->vsel_mask, sel);
> }
>
> -int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
> {
> unsigned int val;
> int ret;
> @@ -87,8 +87,8 @@ int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
> return val;
> }
>
> -int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> - unsigned int sel)
> +static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> + unsigned int sel)
> {
> return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
> rdev->desc->vsel_mask, sel);
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Applied "regulator: bd9571mwv: Statize local symbols" to the regulator tree
2017-05-28 6:02 [PATCH] regulator: bd9571mwv: Statize local symbols Axel Lin
2017-05-28 12:20 ` Marek Vasut
@ 2017-06-06 19:07 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2017-06-06 19:07 UTC (permalink / raw)
To: Axel Lin
Cc: Marek Vasut, Mark Brown, Mark Brown, Marek Vasut, Liam Girdwood,
linux-kernel, linux-kernel
The patch
regulator: bd9571mwv: Statize local symbols
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From cb42b64838654df6e8767d2f4eb8b59dfcd414c5 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Sun, 28 May 2017 14:02:17 +0800
Subject: [PATCH] regulator: bd9571mwv: Statize local symbols
These functions are only used by this driver, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/bd9571mwv-regulator.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
index 8ba206fec31e..c67a83d53c4c 100644
--- a/drivers/regulator/bd9571mwv-regulator.c
+++ b/drivers/regulator/bd9571mwv-regulator.c
@@ -43,7 +43,7 @@ enum bd9571mwv_regulators { VD09, VD18, VD25, VD33, DVFS };
.linear_min_sel = _lmin, \
}
-int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
+static int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
{
unsigned int val;
int ret;
@@ -55,8 +55,8 @@ int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
return val & BD9571MWV_AVS_SET_MONI_MASK;
}
-int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
- unsigned int sel)
+static int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
+ unsigned int sel)
{
int ret;
@@ -68,7 +68,7 @@ int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
rdev->desc->vsel_mask, sel);
}
-int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
+static int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
{
unsigned int val;
int ret;
@@ -87,8 +87,8 @@ int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
return val;
}
-int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
- unsigned int sel)
+static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
+ unsigned int sel)
{
return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
rdev->desc->vsel_mask, sel);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-06 19:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-28 6:02 [PATCH] regulator: bd9571mwv: Statize local symbols Axel Lin
2017-05-28 12:20 ` Marek Vasut
2017-06-06 19:07 ` Applied "regulator: bd9571mwv: Statize local symbols" to the regulator tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).